Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing improvement #4089

Open
guilload opened this issue Nov 6, 2023 · 2 comments
Open

Tracing improvement #4089

guilload opened this issue Nov 6, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@guilload
Copy link
Member

guilload commented Nov 6, 2023

The fact that lookback period exists and defaults to 1d, but retention period of traces is index that is hardcoded in code. So this caused a bit of investigation, as there was a weird situation in Jaeger (our tracing UI) where if you searched traces as a list, it would give you traces older than one day, but if you then hit that one trace directly by ID, it would not be found due to lookback period.

@guilload guilload added the enhancement New feature or request label Nov 6, 2023
@guilload guilload self-assigned this Nov 6, 2023
@fulmicoton
Copy link
Contributor

it might be useful to discuss with @trinity-1686a. They are working in parallel on an optimization that will make this lookback period trick obsolete.

@trinity-1686a
Copy link
Contributor

trinity-1686a commented Nov 7, 2023

the loopback period appear to be used in a few places, but none would be impacted by my changes I believe:

  • get_services => not helped (it's a ListTerms, not a proper search)
  • get_operations => not helped (it's a ListTerms, not a proper search)
  • get_trace => already has the optimization, but it's only useful if we stored more than max_fetch_spans (=10_000) spans.

the thing I'm working on will only impact find_trace_ids (which gets its time bounds from jaeger iiuc). Incidentally, it will also impact find_traces as it performs a find_trace_ids followed by a stream_spans (the core logic of get_trace but the time-bounds are not derived from the loopback period)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants