Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new TermSetQuery::query_terms impl can cause duplicate work in warmup #3629

Closed
trinity-1686a opened this issue Jul 13, 2023 · 0 comments · Fixed by #4192
Closed

new TermSetQuery::query_terms impl can cause duplicate work in warmup #3629

trinity-1686a opened this issue Jul 13, 2023 · 0 comments · Fixed by #4192
Assignees

Comments

@trinity-1686a
Copy link
Contributor

quickwit-oss/tantivy#2120 implements TermSetQuery::query_terms. Before, we relied on it not being implemented to load directly the whole sstable and not have to handle duplicate work (whole table + some terms from the same table).
After, we'll have to do some deduplication to not incure useless calls to the storage.
We can also become smarter than what we currently do: if only a few terms are in the set, we could load only those instead of the whole table. We could also detect common prefix (all terms are from the same json field for instance), and load only a range of the sstable... there are many optimizations this could open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant