From 483af3812686b1cc90e6d4a3b84829badc88ba55 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E7=8E=8B=E5=8B=A4=E5=A5=8B?= Date: Thu, 14 Mar 2024 15:45:26 +0800 Subject: [PATCH 1/2] fix UseDataDictionary=N dataDictionaryProvider is null --- quickfixj-core/src/main/java/quickfix/Session.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/quickfixj-core/src/main/java/quickfix/Session.java b/quickfixj-core/src/main/java/quickfix/Session.java index 80c1782ddc..e5f44ffe25 100644 --- a/quickfixj-core/src/main/java/quickfix/Session.java +++ b/quickfixj-core/src/main/java/quickfix/Session.java @@ -2163,7 +2163,8 @@ private void nextLogon(Message logon) throws FieldNotFound, RejectLogon, Incorre throw new RejectLogon("Logon attempt not within session time"); } - if (sessionID.isFIXT()) { + // UseDataDictionary=N dataDictionaryProvider is null + if (sessionID.isFIXT() && dataDictionaryProvider != null) { final DataDictionary dictionary = dataDictionaryProvider .getSessionDataDictionary(sessionID.getBeginString()); if (dictionary != null) { From 32e432e38cbb15ce8a62e3b92dc1ff8753797de1 Mon Sep 17 00:00:00 2001 From: Christoph John Date: Thu, 14 Mar 2024 14:34:43 +0100 Subject: [PATCH 2/2] removed comment --- quickfixj-core/src/main/java/quickfix/Session.java | 1 - 1 file changed, 1 deletion(-) diff --git a/quickfixj-core/src/main/java/quickfix/Session.java b/quickfixj-core/src/main/java/quickfix/Session.java index e5f44ffe25..06a88b50d9 100644 --- a/quickfixj-core/src/main/java/quickfix/Session.java +++ b/quickfixj-core/src/main/java/quickfix/Session.java @@ -2163,7 +2163,6 @@ private void nextLogon(Message logon) throws FieldNotFound, RejectLogon, Incorre throw new RejectLogon("Logon attempt not within session time"); } - // UseDataDictionary=N dataDictionaryProvider is null if (sessionID.isFIXT() && dataDictionaryProvider != null) { final DataDictionary dictionary = dataDictionaryProvider .getSessionDataDictionary(sessionID.getBeginString());