Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To update the UI for the Wallet Connect init session #179

Closed
Tracked by #148
sallymoc opened this issue Oct 9, 2024 · 5 comments · Fixed by #182 or #205
Closed
Tracked by #148

To update the UI for the Wallet Connect init session #179

sallymoc opened this issue Oct 9, 2024 · 5 comments · Fixed by #182 or #205
Assignees
Milestone

Comments

@sallymoc
Copy link
Contributor

sallymoc commented Oct 9, 2024

It is currently:

image

It should be:
https://www.figma.com/design/uyqKWH9xX5hOz0BjtuzJ7g/Qubic-Wallet-Mobile-App?node-id=1301-3984&t=IDZ8ZZtglQmjuEdx-4

@sallymoc
Copy link
Contributor Author

sallymoc commented Oct 9, 2024

@ahmed-tarek-salem ahmed-tarek-salem linked a pull request Oct 14, 2024 that will close this issue
@sallymoc
Copy link
Contributor Author

sallymoc commented Nov 6, 2024

@ahmed-tarek-salem I can't manage to see the screen for the unsupported network. Maybe it's handle differently after the upgrade to reown.
When using a different network, the app just displays an error with the snackbar message in red background for few seconds.

@ahmed-tarek-salem
Copy link
Contributor

@sallymoc

This is a comment from William on Discord about this:

image

@sallymoc
Copy link
Contributor Author

sallymoc commented Nov 6, 2024

@ahmed-tarek-salem
Please try it and you will see the specific error is received and you can handle from there to display the screen

Image

I reproduced this modifying the qubic chain in the demo dapp to "qubic123:main"

@sallymoc
Copy link
Contributor Author

Unsupported network changed message change as snackbar Image
(we don't have the app information and looks odd to have the full screen message)

@github-project-automation github-project-automation bot moved this from In QA to Done in Wallet App Kanban Board Nov 19, 2024
@sallymoc sallymoc added this to the 1.3.0 milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment