Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented switch not supported. #118

Open
elfner opened this issue Mar 20, 2023 · 4 comments
Open

Documented switch not supported. #118

elfner opened this issue Mar 20, 2023 · 4 comments

Comments

@elfner
Copy link

elfner commented Mar 20, 2023

Hi - the documentation for the installer on the main page suggests --quayStorage is a supported switch, but when specifying it in the latest release (1.2.9), it gives a usage statement error "Error: unknown flag: --quayStorage".

@dmage
Copy link
Contributor

dmage commented Mar 21, 2023

The latest release is 1.3.1, but we didn't have it as a GitHub release. I created releases for new tags. Please check it.

@elfner
Copy link
Author

elfner commented Mar 21, 2023

Thank you. I only see the source bundles, not the mirror-registry-[online|offline].tar.gz bundles as in 1.2.9.

@dmage
Copy link
Contributor

dmage commented Mar 22, 2023

@elfner try v1.3.2 that was released 5 minutes ago :)

@OndrejHome
Copy link
Contributor

I was also surprised by sudden change that moved the storage locations around from 1.3.0 seemingly without any obvious note in release notes in 1.3.0.

As the change requires adding new options to achieve "same results" as before 1.3.0 it would have been nice to mention it somewhere (eg. "due to storage change from 1.3.0 the --quayRoot no longer control location of data and DB storage, use --pgStorage and --quayStorage options for that")

Short summary from what I have seen:

  • in 1.2.9 version (and probably before)
# mirror-registry install --quayRoot /mnt/registry
# ls -1 /mnt/registry
pg-data
quay-config
quay-rootCA
quay-storage
  • from 1.3.0 if only --quayRoot is used, the storage for postgres and quay app will default to volumes in podman which are typically at /var/lib/containers/storage/volumes/.
# mirror-registry install --quayRoot /mnt/registry
# ls -1 /mnt/registry
quay-config
quay-rootCA
# ls -1 /var/lib/containers/storage/volumes/
...
pg-data
quay-storage
  • from 1.3.0 release for results consistent with 1.2.9 behaviour additional options seems to be required
# mirror-registry install --quayRoot /mnt/registry --quayStorage /mnt/registry/quay-storage --pgStorage /mnt/registry/pg-data
# ls -1 /mnt/registry
pg-data
quay-config
quay-rootCA
quay-storage

If above can be in some form included in README that may help the future deployments. Also to stay within what this issue is about - adding 'since 1.3.0' to --quayStorage and --pgStorage documentation might do the trick too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants