database: move db logic to dbutil #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeyboardNerd
changed the title
KeyboardNerd
changed the title
jzelinskie
suggested changes
Mar 6, 2019
api/v3/util.go
Outdated
| for _, feature := range affectedFeatures { | ||
| // TODO(sidac): This is wrong. Based on this usage, we should not | ||
| // return nullable feature at all. |
There was a problem hiding this comment.
Change it to panic then?
database/dbutil.go
Outdated
|
|
||
| defer tx.Rollback() | ||
| noti, found, err = tx.FindVulnerabilityNotification(name, limit, oldVulnerabilityPage, newVulnerabilityPage) | ||
| return |
There was a problem hiding this comment.
return tx.FindVulnerabilityNotification(name, limit, oldVulnerabilityPage, newVulnerabilityPage)
jzelinskie
added
kind/cleanup
Move all transaction related logic to dbutil to simplify and later unify the db interface.
jzelinskie
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incremental clean up