Helm Chart: Use Secret for config file. Fix some minor issues #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Config file for Clair now is inside a Secret. Fixes #581. - Update helper template to use latest Helm conventions for "name" and "fullname". - Update labels to use the recommended labels by Helm. See: https://docs.helm.sh/chart_best_practices/#standard-labels - Remove service.name from values file because it is not used. Service discovery for parent charts can be made by using the "clair.fullname" template since template functions are shared between charts.
jzelinskie
approved these changes
Aug 9, 2018
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config file for Clair now is inside a Secret. Fixes Shouldn't configmap.yaml for the Helm chart be a Secret instead? It contains sensitive information #581.
Update helper template to use latest Helm conventions for "name" and
"fullname".
Update labels to use the recommended labels by Helm. See:
https://docs.helm.sh/chart_best_practices/#standard-labels
Remove service.name from values file because it is not used.
Service discovery for parent charts can be made by using the
"clair.fullname" template since template functions are shared
between charts.