Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updater: Fix Ubuntu's partial update bug. #53

Merged
merged 1 commit into from
Dec 16, 2015
Merged

updater: Fix Ubuntu's partial update bug. #53

merged 1 commit into from
Dec 16, 2015

Conversation

Quentin-M
Copy link
Contributor

Deferring file closing causes too many open files on some platforms!

@jzelinskie
Copy link
Contributor

Just put a comment above both closes, saying how you have to manually close and not use defer due to it operating on function-level scope and LGTM

Deferring file closing causes `too many open files` (exceeding fs.file-max) on some platforms!
Quentin-M pushed a commit that referenced this pull request Dec 16, 2015
updater: Fix Ubuntu's partial update bug.
@Quentin-M Quentin-M merged commit 7ee1481 into master Dec 16, 2015
@Quentin-M Quentin-M deleted the ubdater branch January 19, 2016 18:42
@jzelinskie jzelinskie added kind/bug things are not as they seem reviewed/lgtm labels Mar 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug things are not as they seem
Development

Successfully merging this pull request may close these issues.

2 participants