API: change api port to api addr, rename RunV2 to Run. #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzelinskie
suggested changes
Aug 18, 2017
api/v3/server.go
Outdated
| @@ -149,7 +149,7 @@ func servePrometheus(mux *http.ServeMux) { | |||
|
|
|||
| // Run initializes grpc and grpc gateway api services on the same port | |||
| func Run(GrpcPort int, tlsConfig *tls.Config, CertFile, KeyFile string, store database.Datastore) { | |||
| l, err := net.Listen("tcp", fmt.Sprintf("localhost:%d", GrpcPort)) | |||
| l, err := net.Listen("tcp", fmt.Sprintf(":%d", GrpcPort)) | |||
There was a problem hiding this comment.
Can we pass the whole addr here rather than just the port?
KeyboardNerd
force-pushed
the
ancestry_
branch
from
79cbc64 to
6dded4e
Compare
jzelinskie
suggested changes
Aug 18, 2017
config.example.yaml
Outdated
| # This is an unencrypted endpoint useful for load balancers to check to healthiness of the clair server. | ||
| healthport: 6061 | ||
| healthaddr: 0.0.0.0:6061 |
There was a problem hiding this comment.
wrap these in quotes, just in case it confuses the yaml
addr: "0.0.0.0:6060"
KeyboardNerd
force-pushed
the
ancestry_
branch
from
6dded4e to
d8c8c95
Compare
KeyboardNerd
changed the title
KeyboardNerd
force-pushed
the
ancestry_
branch
from
d8c8c95 to
0151dba
Compare
jzelinskie
approved these changes
Aug 18, 2017
KeyboardNerd
pushed a commit
to KeyboardNerd/clair
that referenced
this pull request
Feb 2, 2018
API: change api port to api addr, rename RunV2 to Run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #446