Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Minor improvement to script.clean.js #564

Closed
dsl101 opened this issue May 12, 2017 · 1 comment
Closed

[Request] Minor improvement to script.clean.js #564

dsl101 opened this issue May 12, 2017 · 1 comment

Comments

@dsl101
Copy link
Contributor

dsl101 commented May 12, 2017

The current implementation of script.clean.js means that if you have a terminal in the /dist folder, you need to change to another directory and back again after each build. Is there any harm in this instead?

shell.rm('-rf', path.resolve(__dirname, '../dist/*'))

It means the actual /dist directory doesn't get deleted and recreated,

@rstoenescu
Copy link
Member

Hi,

This is more of a thing for https://github.com/quasarframework/quasar-template-default rather than this repo.

Pushed commit to the default template. The complete solution is:

shell.rm('-rf', path.resolve(__dirname, '../dist/*'))
shell.rm('-rf', path.resolve(__dirname, '../dist/.*'))

-Razvan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants