Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] Delay in tabs #187

Closed
xereda opened this issue Nov 14, 2016 · 7 comments
Closed

[ios] Delay in tabs #187

xereda opened this issue Nov 14, 2016 · 7 comments

Comments

@xereda
Copy link

xereda commented Nov 14, 2016

Delay in tabs with ios safari.

There is too long a delay to access the tabs in the Safari iOS browser.

I made two gifs to illustrate this.

Safari in MAC OS X: http://g.recordit.co/G7xMI60fV8.gif (working...)

Safari in Iphone 5 (iOS 10): http://g.recordit.co/fWhj3cYC6E.gif (not working...)

I believe we have some inconsistency in that.

Regards,

@rstoenescu
Copy link
Member

Will investigate. Thanks for reporting!

@rstoenescu
Copy link
Member

@rstoenescu rstoenescu changed the title Delay in tabs with ios safari. [ios] Delay in tabs Nov 23, 2016
@xereda
Copy link
Author

xereda commented Nov 23, 2016

Where specifically do I apply this fix? Or will you add this to the standard product?

@rstoenescu
Copy link
Member

That's not a fix. It's just an acknowledgment of a few well known bugs in ios safari browser (the new IE in my opinion).

@xereda
Copy link
Author

xereda commented Nov 23, 2016

I agree ... thanks for the help.

@yeegeek
Copy link

yeegeek commented Dec 16, 2016

First, I want to say this is an awesome framework, this is the framework I've been looking for.

I also come across this problem when I tried to learn this framework, I looked into it, I found this is actually a very small problem.

If you look into the file in the framework > the tab component, file : src/vue-components/tab/Tab.vue

<router-link v-if="route" ref="routerLink" :to="route" :replace="replace" :append="append" :exact="exact"></router-link>
<i v-if="icon" class="q-tabs-icon">{{icon}}</i>

if you could just move the icon into the <router-link></router-link>,like this:

<router-link v-if="route" ref="routerLink" :to="route" :replace="replace" :append="append" :exact="exact">
<i v-if="icon" class="q-tabs-icon">{{icon}}</i>
</router-link>

it would solve the touch delay ( or touch not responding) problem, well, the problem still exists as you must tap on the icon for the router to jump, if you tap on somewhere else not near the icon, it may not, so a perfect fix would put the whole tab content in the <router-link> element?

Thank you for the awesome work.

@rstoenescu
Copy link
Member

@yeegeek Will investigate, thanks! Tabs component is a beast. It must work without routes attached to it so it's a little complicated, but will get this done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants