Skip to content
This repository has been archived by the owner on Nov 8, 2021. It is now read-only.

Installation script should check for ESLint dependencies presence #26

Closed
IlCallo opened this issue Jul 22, 2019 · 1 comment
Closed

Comments

@IlCallo
Copy link
Member

IlCallo commented Jul 22, 2019

Currently the installation script take as assumptiom that ESLint dependencies are already installed by the core, but I guess this is not always the case.
At the very least we should use hasPackage to check for all packages needed by the extension, but that could already be there from the initial project creation.

This could be due to the fact that ESLint is not mandatory, but added when the project is created.
It must also be decided where these dependencies should be put, as per #22 (comment)

Should them be put into AE dependencies? Or as peerDependencies? Or added to the user project package.json?

@IlCallo
Copy link
Member Author

IlCallo commented Apr 14, 2020

Should be fixed by #48

@IlCallo IlCallo closed this as completed Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant