From 2ce8d16a287d4f5134fcb4c99c93a33830923a37 Mon Sep 17 00:00:00 2001 From: Guillaume Smet Date: Mon, 18 Dec 2023 15:53:12 +0100 Subject: [PATCH 1/3] Fix name in Dev Tools matrix Didn't have any consequences except for the name being confusing in the reports. --- .github/workflows/ci-actions-incremental.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-actions-incremental.yml b/.github/workflows/ci-actions-incremental.yml index b813258819c71..e592d235f00ed 100644 --- a/.github/workflows/ci-actions-incremental.yml +++ b/.github/workflows/ci-actions-incremental.yml @@ -597,7 +597,7 @@ jobs: matrix: java: - { - name: "7", + name: "17", java-version: 17, os-name: "ubuntu-latest" } From 7570e2037781e81b2b6e3308e136a4c09cb6f8fc Mon Sep 17 00:00:00 2001 From: Guillaume Smet Date: Mon, 18 Dec 2023 15:58:12 +0100 Subject: [PATCH 2/3] Keep report a bit longer as 2 days is very impractical If you have a failure on Friday, your reports are gone on Monday. --- .github/workflows/ci-actions-incremental.yml | 42 ++++++++------------ 1 file changed, 17 insertions(+), 25 deletions(-) diff --git a/.github/workflows/ci-actions-incremental.yml b/.github/workflows/ci-actions-incremental.yml index e592d235f00ed..1ccfbd45daec6 100644 --- a/.github/workflows/ci-actions-incremental.yml +++ b/.github/workflows/ci-actions-incremental.yml @@ -210,7 +210,7 @@ jobs: target/build-report.json target/gradle-build-scan-url.txt LICENSE.txt - retention-days: 2 + retention-days: 7 calculate-test-jobs: name: Calculate Test Jobs @@ -380,7 +380,7 @@ jobs: with: name: test-reports-jvm${{matrix.java.name}} path: 'test-reports.tgz' - retention-days: 5 + retention-days: 7 - name: Upload build reports (if build failed) uses: actions/upload-artifact@v3 if: ${{ failure() || cancelled() }} @@ -391,15 +391,7 @@ jobs: target/build-report.json target/gradle-build-scan-url.txt LICENSE.txt - retention-days: 2 - - name: Upload gc.log - uses: actions/upload-artifact@v3 - with: - name: "GC log - JDK ${{matrix.java.name}}" - path: | - **/windows-java-17.txt - !**/build/tmp/** - retention-days: 5 + retention-days: 7 - name: Upload build.log (if build failed) uses: actions/upload-artifact@v3 if: ${{ failure() || cancelled() }} @@ -407,7 +399,7 @@ jobs: name: "build-logs-JVM Tests - JDK ${{matrix.java.name}}" path: | **/build.log - retention-days: 2 + retention-days: 7 maven-tests: name: Maven Tests - JDK ${{matrix.java.name}} @@ -485,7 +477,7 @@ jobs: with: name: test-reports-maven-java${{matrix.java.name}} path: 'test-reports.tgz' - retention-days: 5 + retention-days: 7 # see https://github.com/actions/toolkit/blob/master/packages/artifact/docs/additional-information.md#non-supported-characters - name: Rename invalid path if: ${{ failure() || cancelled() }} @@ -503,7 +495,7 @@ jobs: target/build-report.json target/gradle-build-scan-url.txt LICENSE.txt - retention-days: 2 + retention-days: 7 gradle-tests: name: Gradle Tests - JDK ${{matrix.java.name}} @@ -583,7 +575,7 @@ jobs: target/build-report.json target/gradle-build-scan-url.txt LICENSE.txt - retention-days: 2 + retention-days: 7 devtools-tests: name: Devtools Tests - JDK ${{matrix.java.name}} @@ -658,7 +650,7 @@ jobs: with: name: test-reports-devtools-java${{matrix.java.name}} path: 'test-reports.tgz' - retention-days: 5 + retention-days: 7 - name: Upload build reports (if build failed) uses: actions/upload-artifact@v3 if: ${{ failure() || cancelled() }} @@ -669,7 +661,7 @@ jobs: target/build-report.json target/gradle-build-scan-url.txt LICENSE.txt - retention-days: 2 + retention-days: 7 kubernetes-tests: name: Kubernetes Tests - JDK ${{matrix.java.name}} @@ -744,7 +736,7 @@ jobs: with: name: test-reports-kubernetes-java${{matrix.java.name}} path: 'test-reports.tgz' - retention-days: 5 + retention-days: 7 - name: Upload build reports (if build failed) uses: actions/upload-artifact@v3 if: ${{ failure() || cancelled() }} @@ -755,7 +747,7 @@ jobs: target/build-report.json **/target/gradle-build-scan-url.txt LICENSE.txt - retention-days: 2 + retention-days: 7 quickstarts-tests: name: Quickstarts Compilation - JDK ${{matrix.java.name}} @@ -819,7 +811,7 @@ jobs: quarkus-quickstarts/**/target/*-reports/TEST-*.xml quarkus-quickstarts/target/build-report.json quarkus-quickstarts/LICENSE - retention-days: 2 + retention-days: 7 virtual-thread-native-tests: name: Native Tests - Virtual Thread - ${{matrix.category}} @@ -885,7 +877,7 @@ jobs: integration-tests/virtual-threads/**/target/*-reports/TEST-*.xml integration-tests/virtual-threads/target/build-report.json integration-tests/virtual-threads/target/gradle-build-scan-url.txt - retention-days: 2 + retention-days: 7 tcks-test: name: MicroProfile TCKs Tests @@ -949,7 +941,7 @@ jobs: with: name: test-reports-tcks path: 'test-reports.tgz' - retention-days: 5 + retention-days: 7 - name: Upload build reports (if build failed) uses: actions/upload-artifact@v3 if: ${{ failure() || cancelled() }} @@ -960,7 +952,7 @@ jobs: target/build-report.json **/target/gradle-build-scan-url.txt LICENSE.txt - retention-days: 2 + retention-days: 7 native-tests: name: Native Tests - ${{matrix.category}} @@ -1047,7 +1039,7 @@ jobs: with: name: test-reports-native-${{matrix.category}} path: 'test-reports.tgz' - retention-days: 5 + retention-days: 7 - name: Upload build reports (if build failed) uses: actions/upload-artifact@v3 if: ${{ failure() || cancelled() }} @@ -1059,7 +1051,7 @@ jobs: target/build-report.json **/target/gradle-build-scan-url.txt LICENSE.txt - retention-days: 2 + retention-days: 7 build-report: runs-on: ubuntu-latest From 12ed3cd1593bd80630e2ce535bff50b895943bcd Mon Sep 17 00:00:00 2001 From: Guillaume Smet Date: Mon, 18 Dec 2023 15:59:12 +0100 Subject: [PATCH 3/3] Disable gc log on Windows It was a temporary measure to debug something and was kept around since then. --- .github/matrix-jvm-tests.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/matrix-jvm-tests.json b/.github/matrix-jvm-tests.json index 62eabe7448386..4f2654e282c37 100644 --- a/.github/matrix-jvm-tests.json +++ b/.github/matrix-jvm-tests.json @@ -17,6 +17,6 @@ "name": "17 Windows", "java-version": 17, "maven_args": "-DskipDocs -Dformat.skip", - "maven_opts": "-Xmx2g -XX:MaxMetaspaceSize=1g -Xlog:gc*=debug:file=windows-java-17.txt", + "maven_opts": "-Xmx2g -XX:MaxMetaspaceSize=1g", "os-name": "windows-latest" }]