-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smallrye GraphQL 2.5.0 #36348
Smallrye GraphQL 2.5.0 #36348
Conversation
jmartisk
commented
Oct 9, 2023
•
edited
Loading
edited
- test coverage for federation batch resolving
Also cc @robp94 , you authored some parts of this |
81199a2
to
ae88cb1
Compare
Hey @jmartisk Thanks very much. I wonder if we should have 2 PRs, one - bumping the version, some tests, and then a dedicated one related to a new release noteworthy feature ? |
I squashed them into one because the OIDC client integration also relies on new functionality in SR-GQL 2.5.0. Possibly we can split it, but I don't see a strong reason why. One of the PRs would depend on merging the other first. |
@jmartisk Right, the first PR, dealing with the |
ae88cb1
to
2b693d0
Compare
Ok then; I've removed the commit with the new OIDC client extension from this PR.. |
Thanks @jmartisk, your enhancement is worthy a dedicated PR and highlight in the release notes :-) |
This comment has been minimized.
This comment has been minimized.
2b693d0
to
48439ee
Compare
This comment has been minimized.
This comment has been minimized.
TCK test failures seem to be related |
48439ee
to
bba3785
Compare
TCKs should hopefully be fixed now... |
Failing Jobs - Building bba3785
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: integration-tests/rest-client-reactive
📦 integration-tests/rest-client-reactive✖ ⚙️ Maven Tests - JDK 11 Windows #- Failing: integration-tests/maven
📦 integration-tests/maven✖
✖
✖
✖
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice ! Thanks @jmartisk