Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smallrye GraphQL 2.5.0 #36348

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Conversation

jmartisk
Copy link
Contributor

@jmartisk jmartisk commented Oct 9, 2023

  • test coverage for federation batch resolving

@quarkus-bot quarkus-bot bot added area/core area/dependencies Pull requests that update a dependency file area/docstyle issues related for manual docstyle review area/documentation area/graphql area/oidc area/smallrye labels Oct 9, 2023
@jmartisk
Copy link
Contributor Author

jmartisk commented Oct 9, 2023

Also cc @robp94 , you authored some parts of this

@jmartisk jmartisk force-pushed the smallrye-graphql-2.5.0 branch from 81199a2 to ae88cb1 Compare October 9, 2023 10:10
@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Oct 9, 2023
@jmartisk jmartisk requested a review from gsmet October 9, 2023 10:12
@sberyozkin
Copy link
Member

Hey @jmartisk Thanks very much.

I wonder if we should have 2 PRs, one - bumping the version, some tests, and then a dedicated one related to a new release noteworthy feature ?

@jmartisk
Copy link
Contributor Author

jmartisk commented Oct 9, 2023

Hey @jmartisk Thanks very much.

I wonder if we should have 2 PRs, one - bumping the version, some tests, and then a dedicated one related to a new release noteworthy feature ?

I squashed them into one because the OIDC client integration also relies on new functionality in SR-GQL 2.5.0. Possibly we can split it, but I don't see a strong reason why. One of the PRs would depend on merging the other first.

@sberyozkin
Copy link
Member

sberyozkin commented Oct 9, 2023

@jmartisk Right, the first PR, dealing with the smallrye-graphql version bump only would be merged, and then a new PR introducing oidc-client-graphql would be opened, with the label highlighting its introduction - IMHO it is worth it

@jmartisk jmartisk force-pushed the smallrye-graphql-2.5.0 branch from ae88cb1 to 2b693d0 Compare October 9, 2023 11:30
@jmartisk
Copy link
Contributor Author

jmartisk commented Oct 9, 2023

Ok then; I've removed the commit with the new OIDC client extension from this PR..

@sberyozkin
Copy link
Member

Thanks @jmartisk, your enhancement is worthy a dedicated PR and highlight in the release notes :-)

@quarkus-bot

This comment has been minimized.

@jmartisk jmartisk force-pushed the smallrye-graphql-2.5.0 branch from 2b693d0 to 48439ee Compare October 9, 2023 12:11
@quarkus-bot

This comment has been minimized.

@sberyozkin
Copy link
Member

sberyozkin commented Oct 9, 2023

TCK test failures seem to be related

@jmartisk jmartisk force-pushed the smallrye-graphql-2.5.0 branch from 48439ee to bba3785 Compare October 10, 2023 06:59
@jmartisk
Copy link
Contributor Author

TCKs should hopefully be fixed now...

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 10, 2023

Failing Jobs - Building bba3785

Status Name Step Failures Logs Raw logs Build scan
JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
JVM Tests - JDK 20 Build ⚠️ Check → Logs Raw logs
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/rest-client-reactive 

📦 integration-tests/rest-client-reactive

Failed to execute goal uk.co.automatictester:truststore-maven-plugin:3.0.0:generate-truststore (self-signed-truststore) on project quarkus-integration-test-rest-client-reactive: Execution self-signed-truststore of goal uk.co.automatictester:truststore-maven-plugin:3.0.0:generate-truststore failed: java.net.ConnectException: Connection timed out (Connection timed out)


⚙️ Maven Tests - JDK 11 Windows #

- Failing: integration-tests/maven 

📦 integration-tests/maven

io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! Thanks @jmartisk

@phillip-kruger phillip-kruger added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 11, 2023
@jmartisk jmartisk merged commit 61d3986 into quarkusio:main Oct 11, 2023
48 of 51 checks passed
@jmartisk jmartisk deleted the smallrye-graphql-2.5.0 branch October 11, 2023 06:18
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Oct 11, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/docstyle issues related for manual docstyle review area/documentation area/graphql area/oidc area/smallrye
Projects
Development

Successfully merging this pull request may close these issues.

3 participants