Use a dynamic sources encoding during a hot reload compilation #3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwenneg
force-pushed
the
issue-3486-dynamic-hot-reload-sources-encoding
branch
from
d320094
to
64a97e2
Compare
gwenneg
commented
Aug 12, 2019
|
|
||
| this.name = name; | ||
| this.classpath = classpath; | ||
| this.projectDirectory = projectDirectory; | ||
| this.sourceDirectory = sourceDirectory; | ||
| this.outputDirectory = outputDirectory; | ||
| this.sourceEncoding = sourceEncoding == null ? StandardCharsets.UTF_8 : Charset.forName(sourceEncoding); |
There was a problem hiding this comment.
sourceEncoding can't be typed sooner to Charset because DevModeContext is serialized in the Maven and Gradle plugins.
gwenneg
changed the title
|
@aloubyansky: Since the Maven and Gradle plugins are involved in this PR, could you please review it? |
aloubyansky
approved these changes
Aug 12, 2019
aloubyansky
added
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3486