Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fullDocumentBeforeChange to ChangeStreamOptions #34083

Conversation

ruget
Copy link
Contributor

@ruget ruget commented Jun 16, 2023

Add support of fullDocumentBeforeChange option when we register to a change stream from a collection.
This option give the opportunity to have the full document in the change stream events before it has been updated or deleted.

This change allow to activate the option without having to extends the class ChangeStreamOptions.

@ruget ruget force-pushed the ChangeStreamOptionsWithfullDocumentBeforeChange branch 2 times, most recently from f3c19ad to c2c7d6f Compare June 16, 2023 07:08
@gsmet gsmet requested a review from loicmathieu June 16, 2023 12:23
@ruget ruget force-pushed the ChangeStreamOptionsWithfullDocumentBeforeChange branch from c2c7d6f to dfcf6b9 Compare June 16, 2023 16:35
Copy link
Contributor

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quarkus-bot

This comment has been minimized.

@ruget ruget force-pushed the ChangeStreamOptionsWithfullDocumentBeforeChange branch from dfcf6b9 to af4353e Compare July 3, 2023 08:32
@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 3, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 3, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@loicmathieu loicmathieu merged commit f694d96 into quarkusio:main Jul 4, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 4, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Jul 4, 2023
@ruget ruget deleted the ChangeStreamOptionsWithfullDocumentBeforeChange branch July 17, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants