Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use JSON as default data content type for structured JSON encoded events #22835

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Use JSON as default data content type for structured JSON encoded events #22835

merged 1 commit into from
Jan 18, 2022

Conversation

matejvasek
Copy link
Contributor

Signed-off-by: Matej Vasek [email protected]

@matejvasek
Copy link
Contributor Author

/cc @patriot1burke

@matejvasek
Copy link
Contributor Author

from spec:

In some event formats the datacontenttype attribute MAY be omitted. For example, if a JSON format event has no datacontenttype attribute, then it is implied that the data is a JSON value conforming to the "application/json" media type.

gsmet
gsmet approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in. It makes perfect sense and I want to have it for 2.6.3.Final.

Thanks @matejvasek !

@gsmet gsmet merged commit 74314c4 into quarkusio:main Jan 18, 2022
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Jan 18, 2022
@gsmet gsmet modified the milestones: 2.7 - main, 2.6.3.Final Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees

@patriot1burke patriot1burke

Labels
area/funqy
Projects
None yet
Milestone
2.6.3.Final
Development

Successfully merging this pull request may close these issues.
3 participants
@matejvasek @gsmet @patriot1burke