Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop GraalVM / Mandrel 20.3 and 21.1 support #20598

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Drop GraalVM / Mandrel 20.3 and 21.1 support #20598

merged 2 commits into from
Oct 11, 2021

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Oct 7, 2021

No description provided.

@zakkak zakkak changed the title Drop GraalVM / Mandrel 20 3 and 21.1 support Drop GraalVM / Mandrel 20.3 and 21.1 support Oct 7, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 7, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building eba50c9

Status Name Step Failures Logs Raw logs
✖ JVM Tests - JDK 11 Build Failures Logs Raw logs
✖ JVM Tests - JDK 17 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/oidc

📦 integration-tests/oidc

✖ io.quarkus.it.keycloak.WebsocketOidcTestCase.websocketTest line 49 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <hello [email protected]> but was: <null>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/oidc

📦 integration-tests/oidc

✖ io.quarkus.it.keycloak.WebsocketOidcTestCase.websocketTest line 49 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <hello [email protected]> but was: <null>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

@geoand geoand requested review from gastaldi and galderz October 8, 2021 05:36
gastaldi
gastaldi approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@famod
Copy link
Member

famod commented Oct 9, 2021

I cannot comment on the actual changes here but we have many integration-test modules that are setting enable-all-security-services. I guess those should be adjusted as well?

@zakkak zakkak force-pushed the drop-Graal-20-3-support branch from eba50c9 to 3891e6a Compare October 11, 2021 06:10
@zakkak
Copy link
Contributor Author

zakkak commented Oct 11, 2021

I cannot comment on the actual changes here but we have many integration-test modules that are setting enable-all-security-services. I guess those should be adjusted as well?

Thanks @famod, I indeed missed the integration tests and some documentation!

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 11, 2021
gsmet
gsmet approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice (and thorough!) work, thanks!

@gsmet gsmet merged commit 0ae0c6c into quarkusio:main Oct 11, 2021
@quarkus-bot quarkus-bot bot added this to the 2.5 - main milestone Oct 11, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 11, 2021
@zakkak zakkak deleted the drop-Graal-20-3-support branch November 30, 2021 18:46
@gsmet gsmet modified the milestones: 2.5.0.CR1, 2.2.4.Final Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@gsmet gsmet gsmet approved these changes

@gastaldi gastaldi gastaldi approved these changes

@galderz galderz Awaiting requested review from galderz

Assignees
No one assigned
Labels
area/core area/documentation area/fault-tolerance area/graphql area/infinispan Infinispan area/kafka area/kafka-streams area/logging area/mailer area/native-image area/neo4j area/oidc area/security area/smallrye area/undertow area/vertx
Projects
None yet
Milestone
2.2.4.Final
Development

Successfully merging this pull request may close these issues.
5 participants
@zakkak @famod @gastaldi @gsmet @geoand