When using random ports in a docker test, resort to host networking #16903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netodevel
reviewed
Apr 29, 2021
test-framework/common/src/main/java/io/quarkus/test/common/DockerContainerLauncher.java
Outdated
Show resolved
Hide resolved
When a user set `quarkus.http.test-port=0` or `quarkus.http.quarkus.http.test-ssl-port=0`, there is no way to know the port number to expose when launching the container, therefore we need to resort to selecting the random port(s) in the test before launching the container Fixes: quarkusio#16900
|
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building 66c8d71
|
geoand
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using random ports in a docker test, select the port in the test
When a user set
quarkus.http.test-port=0orquarkus.http.quarkus.http.test-ssl-port=0,there is no way to know the port number to expose when launching the container,
therefore we need to resort to selecting the random port(s) in the test
before launching the container
Fixes: #16900