Don't pass --enable-all-security-services to GraalVM >= 21.1 #16584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The option was removed in GraalVM 21.1 oracle/graal#3258
geoand
reviewed
Apr 16, 2021
| @@ -656,7 +656,8 @@ public NativeImageInvokerInfo build() { | |||
| if (!protocols.isEmpty()) { | |||
| nativeImageArgs.add("-H:EnableURLProtocols=" + String.join(",", protocols)); | |||
| } | |||
| if (enableAllSecurityServices) { | |||
| if (enableAllSecurityServices && graalVMVersion.isOlderThan(GraalVM.Version.VERSION_21_1)) { | |||
There was a problem hiding this comment.
Should we log a warning if the flag is not going to be applied?
There was a problem hiding this comment.
I thought about it and decided not to since this flag cannot be deprecated yet (it's still needed by GraalVM 20.3 and 21.1).
Printing a warning here would just confuse users IMO.
Instead I think it's OK to silently skip it in GraalVM >= 21.1 and once we drop support for 20.3 and move to >=21.1 we can deprecate the option and print a warning.
geoand
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option was removed in GraalVM 21.1
oracle/graal#3258