Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small workflow adjustments #16533

Merged
merged 2 commits into from
Apr 16, 2021
Merged

Small workflow adjustments #16533

merged 2 commits into from
Apr 16, 2021

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Apr 15, 2021

Disabling cancel-previous-runs as the bot will take care of this from now on.

@quarkus-bot quarkus-bot bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Apr 15, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 15, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building ac654e7

Status Name Step Test failures Logs Raw logs
✖ Native Tests - Windows - hibernate-validator Build ⚠️ Check → Logs Raw logs

@famod famod mentioned this pull request Apr 15, 2021
Closed
@famod
Copy link
Member

famod commented Apr 15, 2021 •
edited
Loading

This needs a rebase/conflict resolution.

That failure is a known one: #16416

@famod
Copy link
Member

famod commented Apr 15, 2021 •
edited
Loading

Offtopic: @gsmet could the bot also detect merge conflicts? It happened more than once to me that I didn't realize I had a conflict in one of my PRs...

@gsmet
Copy link
Member Author

gsmet commented Apr 15, 2021

Offtopic: @gsmet could the bot also detect merge conflicts? I happened more than once to me that I didn't realize I had a conflict in one of my PRs...

Yeah, I thought about it, the other day. I think it would be doable. There is a mergeable thing on the PR object but its behavior is a bit weird.

@gsmet gsmet force-pushed the workflow-adjustments branch from ac654e7 to 1762fc5 Compare April 15, 2021 18:58
@gsmet
Copy link
Member Author

gsmet commented Apr 15, 2021

Rebased.

@famod famod merged commit 161ff41 into quarkusio:main Apr 16, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 16, 2021
@famod
Copy link
Member

famod commented Apr 18, 2021

@gsmet It just occured to me that in forks people are on their own now, meaning that you have to cancel runs yourself after a push (because the bot doesn't cover forks).
I think we should bring back the action, but limit it to forks. WDYT?

@gsmet
Copy link
Member Author

gsmet commented Apr 19, 2021

Yeah, why not.

This was referenced Apr 19, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@famod famod famod approved these changes

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure
Projects
None yet
Milestone
2.0.0.Alpha1
Development

Successfully merging this pull request may close these issues.
3 participants
@gsmet @famod @geoand