Make it easier to import the project in IDEA #16309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanne
added
area/user-experience
Sanne
commented
Apr 7, 2021
.mvn/jvm.config
Outdated
| @@ -2,3 +2,5 @@ | |||
| -Dmaven.wagon.http.retryHandler.requestSentEnabled=true | |||
| -Dmaven.wagon.http.retryHandler.count=10 | |||
| -Dkotlin.environment.keepalive=true | |||
| -Xmx8g | |||
There was a problem hiding this comment.
@gsmet this would help a lot as people would no longer need to read the instructions prior to importing the project.
But do we have enough physical RAM on CI?
There was a problem hiding this comment.
I am pretty sure that RAM capacity of CI is 8GB
There was a problem hiding this comment.
There was a problem hiding this comment.
ah, thanks @Ladicek . I'll change it to 5 - should be enough.
There was a problem hiding this comment.
BTW doesn't CI override it? I'll change it to 5 just to be sure but I wonder for how long it will be enough :)
There was a problem hiding this comment.
You mean 7 GB? :-) https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
Ah, good point!
There was a problem hiding this comment.
I must say it's a bit sad that just for one IDE (albeit the most popular one as it seems) we now have to set almost three times as much memory than before.
I guess folks with constrainted memory (and who are not using IDEA) can just lower it via MAVEN_OPTS.
Anyway, setting some common value via jvm.config was long overdue. 👍
There was a problem hiding this comment.
yea although to be fair it's unclear how much it's really needing. From what I heard, it's working OK for most people provided they set 2G but some mentioned having to set more; my guess is that 2G is good enough but there's possibly other problems confusing such observations...
So that's why I went with a min and a max heap setting; max to 5G but I hope it will never actually reach to using them all, probably not even half.
Failing Jobs
|
|
thanks @zakkak , applied most of your suggestions and squashed+rebased. |
famod
reviewed
Apr 7, 2021
| @@ -446,17 +462,13 @@ This project is an open source project, please act responsibly, be nice, polite | |||
|
|
|||
| * The Maven build fails with `OutOfMemoryException` | |||
|
|
|||
| Set Maven options to use 1.5GB of heap: `export MAVEN_OPTS="-Xmx1563m"`. | |||
| Set Maven options to use more memory: `export MAVEN_OPTS="-Xmx4g"`. | |||
There was a problem hiding this comment.
With 5g now set in .mvn/jvm.config, the example here doesn't really give it "more memory".
Edit: Corrected.
There was a problem hiding this comment.
True - and technically I think we could remove the section. But I did wonder if someone has a MAVEN_OPTS set, it might override the project settings and get you in trouble - which would be fixed by giving it "more memory" and setting this explicitly.
There was a problem hiding this comment.
Yes, MAVEN_OPTS should override this but my main point is/was that 4 is less than 5. 😉
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs
Test Failures⚙️ JVM Tests - JDK 11 #📦 integration-tests/scala# Tests: 3
+ Success: 1
- Failures: 1
- Errors: 1
! Skipped: 0❌
|
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs
Test Failures⚙️ JVM Tests - JDK 11 #📦 integration-tests/scala# Tests: 3
+ Success: 1
- Failures: 1
- Errors: 1
! Skipped: 0❌
|
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs
Test Failures⚙️ JVM Tests - JDK 11 #📦 integration-tests/scala# Tests: 3
+ Success: 1
- Failures: 1
- Errors: 1
! Skipped: 0❌
|
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs
Test Failures⚙️ JVM Tests - JDK 11 #📦 integration-tests/scala# Tests: 3
+ Success: 1
- Failures: 1
- Errors: 1
! Skipped: 0❌
|
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs
Test Failures⚙️ JVM Tests - JDK 11 #📦 integration-tests/elytron-undertow# Tests: 217
+ Success: 216
- Failures: 1
- Errors: 0
! Skipped: 0❌
|
|
The Scala tests seems to be failing :( |
|
Thanks, I'll have a look at those scala tests. |
|
should work now.. |
geoand
approved these changes
Apr 8, 2021
gastaldi
approved these changes
Apr 8, 2021
Failing Jobs
Test Failures⚙️ JVM Tests - JDK 11 Windows #📦 extensions/resteasy-reactive/quarkus-resteasy-reactive-jsonb/deployment# Tests: 16
+ Success: 14
- Failures: 1
- Errors: 0
! Skipped: 1❌
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.