Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable SSL verification when trust-all property is enabled #16171

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Disable SSL verification when trust-all property is enabled #16171

merged 1 commit into from
Apr 1, 2021

Conversation

glefloch
Copy link
Member

@glefloch glefloch commented Apr 1, 2021

this branch set a sslContext that won't perform any verification. This context is set when quarkus.tls.trust-all is enabled.

close #16119

@glefloch glefloch requested a review from gastaldi April 1, 2021 09:01
@gsmet
Copy link
Member

gsmet commented Apr 1, 2021

Should we check we do a similar thing in the new RESTEasy Reactive client? /cc @michalszynkiewicz @geoand

@michalszynkiewicz
Copy link
Member

@gsmet we don't do that and it's definitely worth doing. I created #16173 not to lose track of it

gastaldi
gastaldi approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gastaldi
Copy link
Contributor

gastaldi commented Apr 1, 2021

I think we should also backport this one?

@gastaldi gastaldi merged commit 542cbfa into quarkusio:main Apr 1, 2021
@quarkus-bot quarkus-bot bot added this to the 1.14 - main milestone Apr 1, 2021
@gsmet gsmet modified the milestones: 1.14 - main, 1.13.1.Final Apr 3, 2021
@glefloch glefloch deleted the fix/16119 branch August 19, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/documentation area/rest-client
Projects
None yet
Milestone
1.13.1.Final
Development

Successfully merging this pull request may close these issues.

quarkus.tls.trust-all=true not working
4 participants
@glefloch @gsmet @michalszynkiewicz @gastaldi