Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime initialization of some imageio related classes #12912

Merged
merged 1 commit into from
Oct 24, 2020

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Oct 23, 2020

Closes: #12535

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be done in core as these classes are in the JDK and it's not a RESTEasy specific thing.

@zakkak
Copy link
Contributor Author

zakkak commented Oct 23, 2020

@gsmet OK, I placed them there because I saw resteasy triggering the instantiation of the classes but you are probably right.

Should I create a new ImageIOProcessor in core or should I use an existing processor? Thanks.

@gsmet
Copy link
Member

gsmet commented Oct 23, 2020

I would create a new one. There's a good chance we will need more logic there :).

@gsmet gsmet merged commit c7e5440 into quarkusio:master Oct 24, 2020
@gsmet
Copy link
Member

gsmet commented Oct 24, 2020

Thanks!

@gsmet gsmet modified the milestones: 1.10 - master, 1.9.1.Final Oct 24, 2020
@gsmet gsmet modified the milestones: 1.9.1.Final, 1.7.6.Final Nov 16, 2020
fniephaus added a commit to hpi-swa/trufflesqueak that referenced this pull request Nov 23, 2020
AWT support in native-image is currently being worked on, so this should be removed in the future.

Related quarkusio/quarkus#12912
fniephaus added a commit to hpi-swa/trufflesqueak that referenced this pull request Nov 23, 2020
AWT support in native-image is currently being worked on, so this should be removed in the future.

Related quarkusio/quarkus#12912
fniephaus added a commit to hpi-swa/trufflesqueak that referenced this pull request Nov 23, 2020
AWT support in native-image is currently being worked on, so this should be removed in the future.

Related quarkusio/quarkus#12912
@zakkak zakkak deleted the fix-12535 branch December 8, 2020 13:51
@zakkak
Copy link
Contributor Author

zakkak commented Dec 10, 2020

@gsmet FYI this will probably not be needed once GraalVM CE 21.0 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants