Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CI coverage for the Hibernate Multi-tenancy integration tests #9389

Closed
Sanne opened this issue May 17, 2020 · 6 comments · Fixed by #9390
Closed

Enable CI coverage for the Hibernate Multi-tenancy integration tests #9389

Sanne opened this issue May 17, 2020 · 6 comments · Fixed by #9390
Assignees
Labels
area/hibernate-orm Hibernate ORM area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/persistence OBSOLETE, DO NOT USE
Milestone

Comments

@Sanne
Copy link
Member

Sanne commented May 17, 2020

Description
We'll need to list the new integration test module <artifactId>quarkus-integration-test-hibernate-tenancy</artifactId> among those running with the MariaDB service enabled.

It also needs to be able to login on MariaDB using the root account, using password secret.

This is a follow-up on #8545

@Sanne Sanne added area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/hibernate-orm Hibernate ORM labels May 17, 2020
@quarkusbot
Copy link

/cc @gsmet @Sanne

@quarkusbot quarkusbot added the area/persistence OBSOLETE, DO NOT USE label May 17, 2020
@Sanne Sanne self-assigned this May 17, 2020
@machi1990
Copy link
Member

Also we should enable native testing: a quick search of the newly added https://github.com/quarkusio/quarkus/tree/master/integration-tests/hibernate-tenancy ITs did not show like it is enabled for native ITs.

@Sanne
Copy link
Member Author

Sanne commented May 18, 2020

@machi1990 right, I believe I did that as well.

@machi1990
Copy link
Member

Great.

@michael-schnell
Copy link
Contributor

Also we should enable native testing: a quick search of the newly added https://github.com/quarkusio/quarkus/tree/master/integration-tests/hibernate-tenancy ITs did not show like it is enabled for native ITs.

At least I tested it manually that it works also in native mode with mvn clean install -Dtest-mariadb -Ddocker -Dnative ;-)

But indeed it would be good to have both options automated with the regular build.

@Sanne
Copy link
Member Author

Sanne commented May 18, 2020

FWIW, we don't run native tests by default as otherwise the build takes way too long for the occasional contributor. But sure, we want this to be tested - included in native - on CI regularly.

that's what my PR is addressing.

@gsmet gsmet added this to the 1.5.0.Final milestone May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hibernate-orm Hibernate ORM area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/persistence OBSOLETE, DO NOT USE
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants