Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to make quarkus-smallrye-openapi return correct response schema for vertx? #8435

Closed
rainmanhhh opened this issue Apr 7, 2020 · 7 comments · Fixed by #10944
Closed

How to make quarkus-smallrye-openapi return correct response schema for vertx? #8435

rainmanhhh opened this issue Apr 7, 2020 · 7 comments · Fixed by #10944
Assignees
Labels
area/openapi area/smallrye kind/question Further information is requested

Comments

@rainmanhhh
Copy link

Please use StackOverflow for questions.

This helps the community to be able to find answers to their similar issues more easily.

Click this link to ask on StackOverflow with the "quarkus" tag.

if I use io.quarkus.vertx.web.Route:

    @Route(methods = [HttpMethod.GET])
    fun hello(rc: RoutingContext) {
        rc.response().end("hello")
    }

localhost:8080/swagger-ui report "No operations defined in spec!"

@rainmanhhh rainmanhhh added the kind/question Further information is requested label Apr 7, 2020
@quarkusbot
Copy link

/cc @EricWittmann

@rainmanhhh
Copy link
Author

I found that with resteasy api(@get @path) and jdk8 CompletionStage, openapi works fine. Will it be a performance bottleneck using resteasy http handler instead of vertx.web?

@EricWittmann
Copy link
Contributor

@phillip-kruger I think we may have another scanner type candidate - vert.x annotations.

@phillip-kruger
Copy link
Member

@EricWittmann cool ! Just not sure if we can assume all @Route is REST Endpoints ?

@rainmanhhh
Copy link
Author

jax-rs annotations is a little bit troublesome(although it's a jsr standard). If you're planning to replace it, what about using openapi annotations instead? (and implement the routing logic with vertx)

@EricWittmann
Copy link
Contributor

@EricWittmann cool ! Just not sure if we can assume all @Route is REST Endpoints ?

No but maybe the scanner can check the methods? I don't really know enough about vert.x to be able to say. But I do know that we have a lot of vert.x experts around. :)

@phillip-kruger
Copy link
Member

I think we need to create a issue in smallrye for this, with some use case examples on how this will work. I.e when do we treat something as a REST endpoint and when not. @rainmanhhh w.d.y.t ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/openapi area/smallrye kind/question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants