Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double GraalVM compatibility effort #6483

Closed
7 tasks
gsmet opened this issue Jan 9, 2020 · 7 comments · Fixed by #6574
Closed
7 tasks

Double GraalVM compatibility effort #6483

gsmet opened this issue Jan 9, 2020 · 7 comments · Fixed by #6574
Milestone

Comments

@gsmet
Copy link
Member

gsmet commented Jan 9, 2020

The idea is to try to support both GraalVM 19.2.1 and GraalVM 19.3.0.2 (we will upgrade to 19.3.1).

  • Create an internal CI job with GraalVM branch https://github.com/oracle/graal/tree/release/graal-vm/19.3 in JDK 11 mode to test Quarkus master (@geoand) -> create proper issues as @gwenneg doesn't have access to it
  • Fix the LocalizationFeature incompatibility (@gwenneg)
  • Go back to 19.2.1 as the default image (@gwenneg)
  • Figure out the JNI situation: forced to enabled for 19.3.1 only (@gwenneg)
  • See if current master works with 19.2.1 or if we need to condition some added substitutions (@gwenneg)
  • Which graal-sdk version should we use? Does both 19.2.1 and 19.3.0 work with the same version?
  • Adjust documentation and website
@geoand
Copy link
Contributor

geoand commented Jan 15, 2020

Now that 19.3.1 is released, we should just rely on it for CI I think and not on the 19.3 branch

@gwenneg
Copy link
Member

gwenneg commented Jan 15, 2020

I can take care of this update as part of the double compatibility final PR which will be submitted tonight.

Unless there's a last minute issue, Quarkus 1.2 will use the GraalVM SDK from 19.2.1 and support native image generation from both GraalVM 19.2.1 and 19.3.1.

@gwenneg
Copy link
Member

gwenneg commented Jan 15, 2020

I forgot we need @cescoffier for the Docker image generation :)

@cescoffier could you please create ubi-quarkus-native-image:19.3.1-java8 and ubi-quarkus-native-image:19.3.1-java11?

@cescoffier
Copy link
Member

@gwenneg push to quay in progress.
See https://github.com/quarkusio/quarkus-images/commit/e391ec4a39b92854419a4e14e2f7ea3ba510738a/checks?check_suite_id=401920973

@geoand
Copy link
Contributor

geoand commented Jan 15, 2020

Things are looking good I think, thanks a lot folks

@geoand
Copy link
Contributor

geoand commented Jan 16, 2020

The latest PR is #6574, correct?

@gwenneg
Copy link
Member

gwenneg commented Jan 17, 2020

@cescoffier Thanks for the push!

@geoand Yes, #6574 is the only PR that is meant to be merged. All other PRs were opened for testing purpose only and most of them have already been closed.

@gsmet gsmet added this to the 1.2.0 milestone Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants