-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSS regression with 1.1.0.CR1 and GraalVM 19.3.0 #6136
Comments
Do we have data from other days? Can we pinpoint when things increased so much? |
Two plots out of my test-suite:
|
Yes, just looking through to pinpoint . @haraldatbmw ty for the data points |
commit 0be78a68 causes the startup RSS to go from 25.9MB to 97.1MB |
There is now a large anon block of memory allocated;
|
Sounds like a regression in GraalVM |
Can you open an issue @johnaohara to the GraalVM team? Let's have conversations early. |
Graal Issue opened: oracle/graal#1984 |
Ah looks like you guys are in the right track (graal issue discussion). I thought about it last night too. Probably a netty buffer which means our old way of keeping it in check is no longer recognized when run under 19.3 CC @stuartwdouglas |
Hello @johnaohara Is there a set of steps to consistently reproduce this using that |
@jaikiran Which platform are you testing on? To reproduce; Build against 19.3.0
You should see the process taking ~63MB of memory Build against 19.2.1
You should see the process taking ~14MB of memory. Those numbers are at startup without sending any requests Yesterday I spent time tracing out calls to allocate native memory. So far I have not found netty allocating any native memory, but I have found this;
I will spend some time this afternoon verifying that this is the cause of the increase in memory. |
Building getting started quickstart with #6574 and 19.3.1, the startup RSS is now the same as building with 19.2.1
|
@gsmet should we continue with the dual version approach or bump to 19.3.1 in light of the results that @johnaohara posted? It's probably too late for the latter... |
@johnaohara I can confirm that the memory usage is in the range it was before. |
We can close this one, everything is OK with 19.3.1. Thanks @johnaohara and @haraldatbmw . |
Describe the bug
Report by Harald Reinmüller on zulip;
Confirmed in the RSS test suite; regression occurred in nightly test on 2019-12-05
The text was updated successfully, but these errors were encountered: