-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide API to create bcrypt hash and salt #5113
Comments
@danielpetisme Hi Daniel, if you can find some time to check this one then it would be nice |
What do you mean by "they will not compile natively"? Is native image generation failing with these JARs, or...? |
Yes, native image generation is failing, below is full output:
|
Ah! I can't believe this bug isn't fixed yet in GraalVM. I'll make a note of it. |
Yes I think that's the same issue. |
I do agree with @gnunn1 without a way to generate bcrypted password the usage of the bcrypt-mapper is limited. Thoughts? |
The short-term fix would be to |
I've been using this one in prod for years: https://github.com/jeremyh/jBCrypt/blob/master/src/main/java/org/mindrot/BCrypt.java Probably it compiles to native, due to not using exotic stuff? |
I don't think |
Ah, I didn't look properly :) |
Actually, for #5660 I need more than this, I need a real Modular Crypt Format implementation to get all iteration/salt/hash in one standard bCrypt string, as documented in https://en.wikipedia.org/wiki/Bcrypt |
Generally, I think our security extensions simply lack support for MCF encoding and always separate the parts, which is less than ideal. I'll open an issue around that. |
The Elytron password library has complete support for MCF. |
Done: #5667 |
OK, fine, it works great :) |
Hi, Is the plan to include this as part of a future update in this module? (I'm not planning to build a native image as of now) |
FYI the upstream bug relating to |
@dmlloyd does that mean we can close this one? |
I think so. |
Unfortunately on my side i had another error when compiling to native (quarkus 1.10.5.Final), if i remove my code and the dependency it compiles without any error. I also tried to include wildfly-common but still having the same issue building quarkus jar
|
You need to use version |
Description
Quarkus provides a bcrypt password mapper for the elyton JDBC security provider but doesn't appear to offer a way to create a bcrypt salt and hash thus limiting it's usefulness. It is possible to do this using JARs from Wildfly however they will not compile natively.
Example using code from Wildfly, pom.xml:
Code:
The text was updated successfully, but these errors were encountered: