Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate extension descriptor from pom.xml #4551

Closed
FroMage opened this issue Oct 14, 2019 · 5 comments
Closed

Generate extension descriptor from pom.xml #4551

FroMage opened this issue Oct 14, 2019 · 5 comments
Labels
kind/enhancement New feature or request triage/out-of-date This issue/PR is no longer valid or relevant

Comments

@FroMage
Copy link
Member

FroMage commented Oct 14, 2019

Follow-up on #4539, it would be nice if we could generate the extension descriptor entirely from pom.xml properties, such as:

<project>
 ...
 <properties>
  <quarkus.extension.name>RESTEasy - Jackson</quarkus.extension.name>
  <quarkus.extension.labels>resteasy-jackson,jaxrs-json,resteasy-json,resteasy,jaxrs,json,jackson</quarkus.extension.labels>
 </properties>
...
</project>
@stale
Copy link

stale bot commented Nov 13, 2019

This issue/pullrequest has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 13, 2019
@FroMage FroMage removed the stale label Nov 13, 2019
@FroMage
Copy link
Member Author

FroMage commented Nov 13, 2019

I don't think we should close this, right @aloubyansky ?

@aloubyansky
Copy link
Member

I think it surely can be implemented. I'll leave it to you as the author of the issue to evaluate its worthiness :)
At this point, if no extra info is provided, the name will derived from the pom.xml or the artifactId https://github.com/quarkusio/quarkus/blob/master/independent-projects/bootstrap/maven-plugin/src/main/java/io/quarkus/maven/ExtensionDescriptorMojo.java#L156
The description is also taken from the pom.xml, unless provided from the outside.
However, the property-based approach as described in the summary above can also be added.

@gsmet
Copy link
Member

gsmet commented Nov 13, 2019

I don't think we want to support several ways of doing the same thing.

We should decide and settle on one approach. TBH, I'm not a big fan of the extraction of the description of the pom.xml, I would have put all the metadata in the yaml file.

I think we should close this one and open another issue if at some point we decide on another approach.

@gastaldi
Copy link
Contributor

+1 on @gsmet's comments above. Closing this

@gastaldi gastaldi added the triage/out-of-date This issue/PR is no longer valid or relevant label Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request triage/out-of-date This issue/PR is no longer valid or relevant
Projects
None yet
Development

No branches or pull requests

4 participants