Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle buildForkOptions no longer used since quarkus 3.16.1 #44438

Closed
Malandril opened this issue Nov 12, 2024 · 5 comments · Fixed by #44493
Closed

Gradle buildForkOptions no longer used since quarkus 3.16.1 #44438

Malandril opened this issue Nov 12, 2024 · 5 comments · Fixed by #44493
Milestone

Comments

@Malandril
Copy link
Contributor

Malandril commented Nov 12, 2024

Describe the bug

Since quarkus 3.16.1 the buildForkOptions in the quarkus extensions is no longer used when running quarkus tasks such as quarkusBuild, or imagePush

Expected behavior

The buildForkOptions should be used to configure the build tasks, and its actions should be applied to QuarkusBuildTask.

Actual behavior

The buildForkOptions is not used, and the configuration actions are not executed

How to Reproduce?

  1. quarkus create app quarkus-bug-jib-proxy --gradle-kotlin-dsl --extension='rest'
  2. Add the following in build.gradle.kts:
quarkus {
    buildForkOptions {
        println("Build fork options")
    }
}

The line is never printed

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

3.16.2

Build tool (ie. output of mvnw --version or gradlew --version)

Gradle 8.10.2

Additional information

The codeGenForkOptions is still correctly used.

Copy link

quarkus-bot bot commented Nov 12, 2024

/cc @geoand (jib,kotlin), @glefloch, @quarkusio/devtools

@geoand
Copy link
Contributor

geoand commented Nov 12, 2024

cc @aloubyansky

@cdsap
Copy link
Contributor

cdsap commented Nov 13, 2024

The QuarkusBuildTask is incorrectly using the CodeGenForkOptions. A fix was created in #44493.

@geoand
Copy link
Contributor

geoand commented Nov 14, 2024

Thanks a lot @cdsap !

@Malandril
Copy link
Contributor Author

Thanks a lot as always @cdsap

@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 14, 2024
@gsmet gsmet modified the milestones: 3.18 - main, 3.16.4 Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants