Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for quarkus.elasticsearch.health.enabled #42020

Closed
gsmet opened this issue Jul 20, 2024 · 2 comments · Fixed by #42280
Closed

Add a test for quarkus.elasticsearch.health.enabled #42020

gsmet opened this issue Jul 20, 2024 · 2 comments · Fixed by #42280

Comments

@gsmet
Copy link
Member

gsmet commented Jul 20, 2024

In extensions/elasticsearch-rest-client/, there is no test for the config property quarkus.elasticsearch.health.enabled and we should add one.

The test should be in the deployment module with the others.

Tests of this module can be run with mvn clean install -Dstart-containers -Dtest-containers so that Testcontainers start an Elasticsearch cluster.
Run this command in the module once you have build Quarkus with ./mvnw -Dquickly.

This looks like a good first issue.

Copy link

quarkus-bot bot commented Jul 20, 2024

/cc @jmartisk (health), @loicmathieu (elasticsearch), @marko-bekhta (elasticsearch), @xstefank (health), @yrodiere (elasticsearch)

@gsmet
Copy link
Member Author

gsmet commented Jul 20, 2024

In relation to #42021 as I had to test things manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant