Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a broken xref to configuration-based-tenant-resolver #41649

Closed
rolfedh opened this issue Jul 3, 2024 · 3 comments · Fixed by #41650
Closed

Fix a broken xref to configuration-based-tenant-resolver #41649

rolfedh opened this issue Jul 3, 2024 · 3 comments · Fixed by #41650
Labels
area/config area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Milestone

Comments

@rolfedh
Copy link
Contributor

rolfedh commented Jul 3, 2024

Description

The product docs are getting the following error

Transforming the AsciiDoc content to DocBook XML...
�[31m�[1mUnknown ID or title "configuration-based-tenant-resolver", used as an internal cross reference�[0m
�[31m�[1mUnknown ID or title "configuration-based-tenant-resolver", used as an internal cross reference�[0m
�[31m�[1m/root/doc-source/pantheon/security-oidc-authentication/build/en-US/master.xml fails to validate�[0m

This happens because the because asciidoc/_generated/config/quarkus-oidc.adoc contains the following cross reference:

Please see the xref:security-openid-connect-multitenancy.adoc#configuration-based-tenant-resolver[Resolve with configuration] section of the OIDC multitenancy guide for explanation of allowed path patterns.

This cross reference uses an obsolete ID and title for a section in /asciidoc/security-openid-connect-multitenancy.adoc. It seems like the ID and title of the intended section are as follows:

[[configure-tenant-paths]]
==== Configure tenant paths

To fix this I propose updating extensions/oidc/runtime/src/main/java/io/quarkus/oidc/OidcTenantConfig.java with the new ID and title.

Implementation ideas

No response

@rolfedh rolfedh added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Jul 3, 2024
Copy link

quarkus-bot bot commented Jul 3, 2024

/cc @radcortez (config)

@rolfedh
Copy link
Contributor Author

rolfedh commented Jul 3, 2024

@sberyozkin

@rolfedh
Copy link
Contributor Author

rolfedh commented Jul 3, 2024

Also see: 

No CP to 3.8 => quarkus-3-8 needed. This content doesn't exist there.

@gsmet gsmet added this to the 3.12.2 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Projects
None yet
2 participants