Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow quarkus.application.name to be overridden for Spring Cloud Config Server #41011

Closed
thibaultmeyer opened this issue Jun 6, 2024 · 3 comments · Fixed by #41035
Closed
Labels
area/config area/spring Issues relating to the Spring integration kind/enhancement New feature or request
Milestone

Comments

@thibaultmeyer
Copy link
Contributor

thibaultmeyer commented Jun 6, 2024

Description

The ‘Spring Cloud Configuration’ extension uses the quarkus.application.name property to determine the configuration files to be loaded on the remote server. This works, but can lead to problems when there are multiple files to load. The property no longer corresponds to anything.

quarkus.application.name=common,dc1,my-application
quarkus.application.version=2.62.3

quarkus.spring-cloud-config.enabled=true
quarkus.spring-cloud-config.fail-fast=true
quarkus.spring-cloud-config.url=https://xxxxxx/spring-config-server/

In this example, the quarkus.application.name option loses its usefulness because the extension forces you to enter information that has nothing to do with the name of the application.

Implementation ideas

It could be nice to implement a new property quarkus.spring-cloud-config.names (default value is quarkus.application.name)

Example

quarkus.application.name=my-application
quarkus.application.version=2.62.3

quarkus.spring-cloud-config.enabled=true
quarkus.spring-cloud-config.fail-fast=true
quarkus.spring-cloud-config.names=common,dc1,my-application
quarkus.spring-cloud-config.url=https://xxxxxx/spring-config-server/
@thibaultmeyer thibaultmeyer added the kind/enhancement New feature or request label Jun 6, 2024
@quarkus-bot quarkus-bot bot added area/config area/spring Issues relating to the Spring integration labels Jun 6, 2024
Copy link

quarkus-bot bot commented Jun 6, 2024

/cc @geoand (spring), @radcortez (config)

@geoand
Copy link
Contributor

geoand commented Jun 6, 2024

Sounds interesting.

Would you be willing to add this new feature?

@thibaultmeyer
Copy link
Contributor Author

hi @geoand,

no problem, I'm looking into opening an enhancement PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config area/spring Issues relating to the Spring integration kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants