Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global OIDC TokenCustomizer is ignored #39799

Closed
michalvavrik opened this issue Mar 30, 2024 · 4 comments
Closed

Global OIDC TokenCustomizer is ignored #39799

michalvavrik opened this issue Mar 30, 2024 · 4 comments
Assignees
Labels
area/oidc kind/bug Something isn't working

Comments

@michalvavrik
Copy link
Member

michalvavrik commented Mar 30, 2024

Describe the bug

* Custom token customizers without a {@link TenantFeature} qualifier will be bound to all OIDC tenants.

says that the customizer without @TenantFeature is tied to every tenant. Strictly speaking I didn't try it, but after reading code I'm sure it doesn't work. We only inject customizer with the @TenantFeature from start - #33319.

Expected behavior

Javadocs says it should work.

Actual behavior

I expect that customizer is ignored.

How to Reproduce?

Drop @TenantFeature from ITs.

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

I'd like to refactor how @TenantFeature is used with the TokenCustomizer and JWT Validator and I can fix this as part of that (that's why I'm opening this issue). Noone has complained so far, which tells me it is unlikely this feature is frequently used in a global scope.

It is not documented outside of the interface Javadoc.

@michalvavrik michalvavrik added the kind/bug Something isn't working label Mar 30, 2024
Copy link

quarkus-bot bot commented Mar 30, 2024

/cc @pedroigor (oidc), @sberyozkin (oidc)

@michalvavrik michalvavrik self-assigned this Mar 30, 2024
@michalvavrik michalvavrik changed the title Global OIDC TokenCustomizer is gnored Global OIDC TokenCustomizer is ignored Mar 30, 2024
@sberyozkin
Copy link
Member

There should be a test for the global one

@michalvavrik
Copy link
Member Author

There should be a test for the global one

I looked for it before I opened this issue. I'll try it eventually (not today), but I can't imagine how could it possibly work when I didn't find a code that does that. Anyway, I can be wrong.

@michalvavrik
Copy link
Member Author

This issue will become irrelevant with recent refactoring of this feature - #40525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/oidc kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants