Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus should use HybridJacksonPool with Loom #39738

Closed
franz1981 opened this issue Mar 27, 2024 · 2 comments · Fixed by #39739
Closed

Quarkus should use HybridJacksonPool with Loom #39738

franz1981 opened this issue Mar 27, 2024 · 2 comments · Fixed by #39739
Labels
area/jackson Issues related to Jackson (JSON library) kind/bug Something isn't working
Milestone

Comments

@franz1981
Copy link
Contributor

franz1981 commented Mar 27, 2024

Describe the bug

Using Java 21 (with ) and running the test at https://github.com/franz1981/fortune-benchmark/blob/main/fortune-virtual-thread-mariadb/src/test/java/me/escoffier/fortune/virtual/reactive/mariadb/test/FortuneApiTest.java

with the branch at #39704

this is the reported stack trace:

<init>:289, RecyclerPool$LockFreePoolBase (com.fasterxml.jackson.core.util)
<init>:214, JsonRecyclerPools$LockFreePool (com.fasterxml.jackson.core.util)
<clinit>:209, JsonRecyclerPools$LockFreePool (com.fasterxml.jackson.core.util)
newLockFreePool:85, JsonRecyclerPools (com.fasterxml.jackson.core.util)
defaultPool:29, JsonRecyclerPools (com.fasterxml.jackson.core.util)
<init>:376, JsonFactory (com.fasterxml.jackson.core)
<init>:29, MappingJsonFactory (com.fasterxml.jackson.databind)
<init>:682, ObjectMapper (com.fasterxml.jackson.databind)
<init>:605, ObjectMapper (com.fasterxml.jackson.databind)
objectMapper:31, ObjectMapperProducer (io.quarkus.jackson.runtime)
doCreate:-1, ObjectMapperProducer_ProducerMethod_objectMapper_0pJSAzCVhvpc3iOoOyAlWRwtODI_Bean (io.quarkus.jackson.runtime)
create:-1, ObjectMapperProducer_ProducerMethod_objectMapper_0pJSAzCVhvpc3iOoOyAlWRwtODI_Bean (io.quarkus.jackson.runtime)
create:-1, ObjectMapperProducer_ProducerMethod_objectMapper_0pJSAzCVhvpc3iOoOyAlWRwtODI_Bean (io.quarkus.jackson.runtime)
createInstanceHandle:119, AbstractSharedContext (io.quarkus.arc.impl)
get:38, AbstractSharedContext$1 (io.quarkus.arc.impl)
get:35, AbstractSharedContext$1 (io.quarkus.arc.impl)
get:32, LazyValue (io.quarkus.arc.impl)
computeIfAbsent:69, ComputingCache (io.quarkus.arc.impl)
computeIfAbsent:19, ComputingCacheContextInstances (io.quarkus.arc.impl)
get:35, AbstractSharedContext (io.quarkus.arc.impl)
get:-1, ObjectMapperProducer_ProducerMethod_objectMapper_0pJSAzCVhvpc3iOoOyAlWRwtODI_Bean (io.quarkus.jackson.runtime)
get:-1, ObjectMapperProducer_ProducerMethod_objectMapper_0pJSAzCVhvpc3iOoOyAlWRwtODI_Bean (io.quarkus.jackson.runtime)
doCreate:-1, BasicServerJacksonMessageBodyWriter_Bean (io.quarkus.resteasy.reactive.jackson.runtime.serialisers)
create:-1, BasicServerJacksonMessageBodyWriter_Bean (io.quarkus.resteasy.reactive.jackson.runtime.serialisers)
get:-1, BasicServerJacksonMessageBodyWriter_Bean (io.quarkus.resteasy.reactive.jackson.runtime.serialisers)
get:-1, BasicServerJacksonMessageBodyWriter_Bean (io.quarkus.resteasy.reactive.jackson.runtime.serialisers)
beanInstanceHandle:559, ArcContainerImpl (io.quarkus.arc.impl)
beanInstanceHandle:539, ArcContainerImpl (io.quarkus.arc.impl)
beanInstanceHandle:572, ArcContainerImpl (io.quarkus.arc.impl)
get:331, ArcContainerImpl$3 (io.quarkus.arc.impl)
get:328, ArcContainerImpl$3 (io.quarkus.arc.impl)
create:58, BeanContainerImpl$1 (io.quarkus.arc.runtime)
createInstance:27, ArcBeanFactory (io.quarkus.resteasy.reactive.common.runtime)
instance:80, ResourceWriter (org.jboss.resteasy.reactive.common.model)
toMessageBodyWriters:199, Serialisers (org.jboss.resteasy.reactive.common.core)
findBuildTimeWriters:150, Serialisers (org.jboss.resteasy.reactive.common.core)
buildResourceMethod:426, RuntimeResourceDeployment (org.jboss.resteasy.reactive.server.core.startup)
deploy:136, RuntimeDeploymentManager (org.jboss.resteasy.reactive.server.core.startup)
createDeployment:150, ResteasyReactiveRecorder (io.quarkus.resteasy.reactive.server.runtime)
deploy_0:-1, ResteasyReactiveProcessor$setupDeployment713137389 (io.quarkus.deployment.steps)
deploy:-1, ResteasyReactiveProcessor$setupDeployment713137389 (io.quarkus.deployment.steps)
<clinit>:-1, ApplicationImpl (io.quarkus.runner)
forName0:-1, Class (java.lang)
forName:534, Class (java.lang)
forName:513, Class (java.lang)
run:269, StartupActionImpl (io.quarkus.runner.bootstrap)
doJavaStart:252, QuarkusTestExtension (io.quarkus.test.junit)
ensureStarted:610, QuarkusTestExtension (io.quarkus.test.junit)
beforeAll:660, QuarkusTestExtension (io.quarkus.test.junit)
lambda$invokeBeforeAllCallbacks$12:396, ClassBasedTestDescriptor (org.junit.jupiter.engine.descriptor)
execute:-1, ClassBasedTestDescriptor$$Lambda/0x00007f756c10ac68 (org.junit.jupiter.engine.descriptor)
execute:73, ThrowableCollector (org.junit.platform.engine.support.hierarchical)
invokeBeforeAllCallbacks:396, ClassBasedTestDescriptor (org.junit.jupiter.engine.descriptor)
before:212, ClassBasedTestDescriptor (org.junit.jupiter.engine.descriptor)
before:85, ClassBasedTestDescriptor (org.junit.jupiter.engine.descriptor)
lambda$executeRecursively$6:148, NodeTestTask (org.junit.platform.engine.support.hierarchical)
execute:-1, NodeTestTask$$Lambda/0x00007f756c0bfcc0 (org.junit.platform.engine.support.hierarchical)
execute:73, ThrowableCollector (org.junit.platform.engine.support.hierarchical)
lambda$executeRecursively$8:141, NodeTestTask (org.junit.platform.engine.support.hierarchical)
invoke:-1, NodeTestTask$$Lambda/0x00007f756c0bfaa0 (org.junit.platform.engine.support.hierarchical)
around:137, Node (org.junit.platform.engine.support.hierarchical)
lambda$executeRecursively$9:139, NodeTestTask (org.junit.platform.engine.support.hierarchical)
execute:-1, NodeTestTask$$Lambda/0x00007f756c0bf160 (org.junit.platform.engine.support.hierarchical)
execute:73, ThrowableCollector (org.junit.platform.engine.support.hierarchical)
executeRecursively:138, NodeTestTask (org.junit.platform.engine.support.hierarchical)
execute:95, NodeTestTask (org.junit.platform.engine.support.hierarchical)
accept:-1, SameThreadHierarchicalTestExecutorService$$Lambda/0x00007f756c0ba8d0 (org.junit.platform.engine.support.hierarchical)
forEach:1596, ArrayList (java.util)
invokeAll:41, SameThreadHierarchicalTestExecutorService (org.junit.platform.engine.support.hierarchical)
lambda$executeRecursively$6:155, NodeTestTask (org.junit.platform.engine.support.hierarchical)
execute:-1, NodeTestTask$$Lambda/0x00007f756c0bfcc0 (org.junit.platform.engine.support.hierarchical)
execute:73, ThrowableCollector (org.junit.platform.engine.support.hierarchical)
lambda$executeRecursively$8:141, NodeTestTask (org.junit.platform.engine.support.hierarchical)
invoke:-1, NodeTestTask$$Lambda/0x00007f756c0bfaa0 (org.junit.platform.engine.support.hierarchical)
around:137, Node (org.junit.platform.engine.support.hierarchical)
lambda$executeRecursively$9:139, NodeTestTask (org.junit.platform.engine.support.hierarchical)
execute:-1, NodeTestTask$$Lambda/0x00007f756c0bf160 (org.junit.platform.engine.support.hierarchical)
execute:73, ThrowableCollector (org.junit.platform.engine.support.hierarchical)
executeRecursively:138, NodeTestTask (org.junit.platform.engine.support.hierarchical)
execute:95, NodeTestTask (org.junit.platform.engine.support.hierarchical)
submit:35, SameThreadHierarchicalTestExecutorService (org.junit.platform.engine.support.hierarchical)
execute:57, HierarchicalTestExecutor (org.junit.platform.engine.support.hierarchical)
execute:54, HierarchicalTestEngine (org.junit.platform.engine.support.hierarchical)
execute:198, EngineExecutionOrchestrator (org.junit.platform.launcher.core)
execute:169, EngineExecutionOrchestrator (org.junit.platform.launcher.core)
execute:93, EngineExecutionOrchestrator (org.junit.platform.launcher.core)
lambda$execute$0:58, EngineExecutionOrchestrator (org.junit.platform.launcher.core)
accept:-1, EngineExecutionOrchestrator$$Lambda/0x00007f756c0a3cf8 (org.junit.platform.launcher.core)
withInterceptedStreams:141, EngineExecutionOrchestrator (org.junit.platform.launcher.core)
execute:57, EngineExecutionOrchestrator (org.junit.platform.launcher.core)
execute:103, DefaultLauncher (org.junit.platform.launcher.core)
execute:85, DefaultLauncher (org.junit.platform.launcher.core)
execute:47, DelegatingLauncher (org.junit.platform.launcher.core)
execute:63, SessionPerRequestLauncher (org.junit.platform.launcher.core)
startRunnerWithArgs:57, JUnit5IdeaTestRunner (com.intellij.junit5)
execute:38, IdeaTestRunner$Repeater$1 (com.intellij.rt.junit)
repeat:11, TestsRepeater (com.intellij.rt.execution.junit)
startRunnerWithArgs:35, IdeaTestRunner$Repeater (com.intellij.rt.junit)
prepareStreamsAndStart:232, JUnitStarter (com.intellij.rt.junit)
main:55, JUnitStarter (com.intellij.rt.junit)

which shows that #38196 is not kickin-in

The same data information can be retrieved while acquiring buffers out of the pool

image

@franz1981 franz1981 added the kind/bug Something isn't working label Mar 27, 2024
@quarkus-bot quarkus-bot bot added the area/jackson Issues related to Jackson (JSON library) label Mar 27, 2024
Copy link

quarkus-bot bot commented Mar 27, 2024

/cc @geoand (jackson), @gsmet (jackson)

@franz1981
Copy link
Contributor Author

ading @mariofusco who worked on this

@quarkus-bot quarkus-bot bot added this to the 3.10 - main milestone Mar 28, 2024
@gsmet gsmet modified the milestones: 3.10 - main, 3.8.4 Apr 2, 2024
@gsmet gsmet modified the milestones: 3.8.4, 3.9.3 Apr 9, 2024
@gsmet gsmet modified the milestones: 3.9.3, 3.8.5 May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jackson Issues related to Jackson (JSON library) kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants