-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add details about relocations into README and/or CONTRIBUTING #38274
Comments
I am not exactly sure what you would like to have documented around this. Who do you envision will be helped by such documentation and how? |
|
same question as @geoand - not following what the usecase is? isn't that profile not only to use when publishing - and not needed elsewhere? |
I created #38341 to show my idea. This is the main trigger: quarkus-qe/quarkus-test-suite#1617 (comment) |
had a quick chat with @gsmet and the reason we do not enable by default is to make sure its noticed by extension writers or users that the artifact names are changing. If we enable by default these issues would not be noticed until its too late. Those (like QE) that want to maintain a build that works on both branches should enable the -Drelocation knowing that its fine to do so but they might at least from time to time test withuot relocations to detect possible issues. |
Makes sense, thanks for the context. |
@maxandersen ok, so it's intentionally hidden and this should be closed (together with my PR)? |
Description
I don't see in Quarkus README or CONTRIBUTING documents any suggestion to use relocations profile.
This can be handy for people working with Quarkus main. Especially after #38190 change and with the upcoming https://github.com/quarkusio/quarkus/blob/main/adr/0002-reactive-rename.adoc changes.
CI is building Quarkus main with relocations:
CC @gsmet @geoand
Implementation ideas
No response
The text was updated successfully, but these errors were encountered: