Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qute-web to the platform #37000

Closed
ia3andy opened this issue Nov 10, 2023 · 23 comments · Fixed by quarkusio/quarkus-platform#1049
Closed

Add qute-web to the platform #37000

ia3andy opened this issue Nov 10, 2023 · 23 comments · Fixed by quarkusio/quarkus-platform#1049
Labels
area/qute The template engine

Comments

@ia3andy
Copy link
Contributor

ia3andy commented Nov 10, 2023

As this is now controlling Qute RESTEasy (Classic and Reactive) and this is a very important extension for the Quarkus Web story, Qute Web should be part of the Quarkus Platform.

When it's in the platform, we should unlist Qute RESTEasy (Classic and Reactive).

@quarkus-bot quarkus-bot bot added the area/qute The template engine label Nov 10, 2023
Copy link

quarkus-bot bot commented Nov 10, 2023

/cc @mkouba (qute)

@maxandersen
Copy link
Member

will this extension be affected by the future suggested rename/change of removing reactive from names?

@ia3andy
Copy link
Contributor Author

ia3andy commented Nov 14, 2023

@aloubyansky how should we do this?

@aloubyansky
Copy link
Member

if it's a single extension we could add it to the quarkus-bom in the platform.

@ia3andy
Copy link
Contributor Author

ia3andy commented Nov 14, 2023

@aloubyansky will that make it part of the paltform on code.quarkus.io

@aloubyansky
Copy link
Member

Yes

@ia3andy
Copy link
Contributor Author

ia3andy commented Nov 14, 2023

ok so let's wait for the 3.0.0 of quarkus-qute-web and add it there :)

@ia3andy
Copy link
Contributor Author

ia3andy commented Nov 15, 2023

We will need to put qute-web in the platform in between the core release 3.6.0 and the platform release (because qute-web 3.0.0 will need to be released with 3.6.0 core).

@gsmet is there something specific to do in order to plan this?

@maxandersen
Copy link
Member

Unlisting is just on code.quarkus ui, right?

The extension can still be referenced in cli and code.quarkus rest api ?

@ia3andy
Copy link
Contributor Author

ia3andy commented Nov 15, 2023

Yes

@ia3andy
Copy link
Contributor Author

ia3andy commented Nov 15, 2023

and also maybe for the extensions page @holly-cummins? I think it makes sense to unlist it from there to.

@ia3andy
Copy link
Contributor Author

ia3andy commented Nov 15, 2023

@maxandersen stupid question, why would it be a problem not to have it usable in CLI? Those extensions are useless by themselves as soon as we have the conditional system.

@ia3andy
Copy link
Contributor Author

ia3andy commented Nov 15, 2023

Yeah I tested quarkus-arc is not in quarkus.io/extensions (it's unlisted) which is a good thing

@mkouba
Copy link
Contributor

mkouba commented Nov 27, 2023

if it's a single extension we could add it to the quarkus-bom in the platform.

@aloubyansky What exactly does it involve? Are there instructions pls?

@aloubyansky
Copy link
Member

@mkouba
Copy link
Contributor

mkouba commented Nov 27, 2023

@aloubyansky
Copy link
Member

Yes

@maxandersen
Copy link
Member

@maxandersen stupid question, why would it be a problem not to have it usable in CLI? Those extensions are useless by themselves as soon as we have the conditional system.

Only if you are on that specific version that has it - cli needs to continue to work for older versions. I don't know which extensions you are referring to as useless so can't answer your question fully.

@maxandersen
Copy link
Member

will this extension be affected by the future suggested rename/change of removing reactive from names?

Didn't see reply to this - any concerns/actions there ?

@mkouba
Copy link
Contributor

mkouba commented Nov 27, 2023

will this extension be affected by the future suggested rename/change of removing reactive from names?

Didn't see reply to this - any concerns/actions there ?

I don't think so. Except that we'll have to update the conditional dependencies on resteasy integration modules...

@ia3andy WDYT?

@ia3andy
Copy link
Contributor Author

ia3andy commented Nov 27, 2023

@maxandersen stupid question, why would it be a problem not to have it usable in CLI? Those extensions are useless by themselves as soon as we have the conditional system.

Only if you are on that specific version that has it - cli needs to continue to work for older versions. I don't know which extensions you are referring to as useless so can't answer your question fully.

Ok, the unlisted flag is platform induced so we are fine.

Regarding the change of name I don't think either, like Martin said

@rsvoboda
Copy link
Member

rsvoboda commented Dec 4, 2023

Shouldn't be this mentioned in https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.6?
Or maybe even in https://quarkus.io/blog/quarkus-3-6-0-released/ (if edits are ok-ish)

@ia3andy
Copy link
Contributor Author

ia3andy commented Dec 4, 2023

Shouldn't be this mentioned in https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.6? Or maybe even in https://quarkus.io/blog/quarkus-3-6-0-released/ (if edits are ok-ish)

#37478 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/qute The template engine
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants