Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable OracleOpenTelemetryJdbcInstrumentationTest #36141

Closed
brunobat opened this issue Sep 25, 2023 · 6 comments · Fixed by #36280
Closed

Enable OracleOpenTelemetryJdbcInstrumentationTest #36141

brunobat opened this issue Sep 25, 2023 · 6 comments · Fixed by #36280
Labels
area/tracing good first issue Good for newcomers kind/enhancement New feature or request
Milestone
3.5.0.CR1

Comments

@brunobat
Copy link
Contributor

Description

Test was disabled here because the supporting docker image was buggy
#36140

Implementation ideas

No response
@brunobat brunobat added the kind/enhancement New feature or request label Sep 25, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 25, 2023

/cc @radcortez (opentelemetry)

@brunobat brunobat added the good first issue Good for newcomers label Sep 25, 2023
@michalvavrik michalvavrik mentioned this issue Sep 25, 2023
Merged
@brunobat
Copy link
Contributor Author

@vimalJD no need to write on bold. Please check good first issue Good for newcomers for good first issues.

@navinyashende
Copy link
Contributor

I would like to work on this. Can this be assigned to me?

@brunobat
Copy link
Contributor Author

brunobat commented Oct 3, 2023

Sure @navinyashende, please go ahead.
It should be simply to bring back the code that was removed in #36140

@navinyashende navinyashende mentioned this issue Oct 4, 2023
Merged
@navinyashende
Copy link
Contributor

Raised a PR. Would really appreciate if the hacktoberfest-accepted label can be added to the PR. Pardon me if the hacktoberfest issues are different ones

@brunobat brunobat moved this from Todo to In Progress in Quarkus Roadmap/Planning Oct 4, 2023
@brunobat
Copy link
Contributor Author

brunobat commented Oct 4, 2023

Hi @navinyashende, the quarkus repo already has the label:
Screenshot 2023-10-04 at 09 19 53
Isn't that enough?

@github-project-automation github-project-automation bot moved this from In Progress to Done in Quarkus Roadmap/Planning Oct 4, 2023
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/tracing good first issue Good for newcomers kind/enhancement New feature or request
Projects
Quarkus Roadmap/Planning
Status: Done
Milestone
3.5.0.CR1
Development

Successfully merging a pull request may close this issue.

Enable OracleOpenTelemetryJdbcInstrumentationTest navinyashende/quarkus
2 participants
@brunobat @navinyashende