-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSRF extension breaks applications due to required config #35530
Comments
/cc @pedroigor (bearer-token), @sberyozkin (bearer-token,jwt,security) |
We should definitely have some kind of test for this... @FroMage are you planning on addressing this issue? |
@FroMage Can you clarify please ? What exactly is broken ? |
@FroMage Or yeah, I'll just make it optional, |
@FroMage Sigh, the whole optional One thing that I don't think we can do is to add support for the header at the cost of dropping support for the hidden form fields - which will happen if we have a default header value. Supporting the internal fields for HTML form requests is essential. |
@FroMage Ignore me please, just configuring the default header value does not mean it will be present, should be a simple fix |
@FroMage This is fixed, see the linked PR, I now recall that this property was originally optional and hence I had it configured, then we agreed it should not be optional but I forgot to remove the test configuration which is why I missed that it had no default value... |
CSRF, after #34555 got merged, now requires a config value which should have a default, thus breaking the Quarkus tenet that importing an extension should not break an application by requiring things that have proper defaults.
As such, it breaks every extension user, even if they're not using headers for CSRF, so that's pretty serious.
The text was updated successfully, but these errors were encountered: