Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build time analytics message shown at the start up time #34284

Open
sberyozkin opened this issue Jun 23, 2023 · 13 comments
Open

Improve build time analytics message shown at the start up time #34284

sberyozkin opened this issue Jun 23, 2023 · 13 comments
Assignees
Labels
area/devmode kind/enhancement New feature or request

Comments

@sberyozkin
Copy link
Member

sberyozkin commented Jun 23, 2023

Description

The following message is shown at the start up time with 3.2.0.CR1:

********************************************************************************************************
********************************************************************************************************
********************************************************************************************************

* Please help improve Quarkus!
* Learn more: https://quarkus.io/usage/
* Do you agree to contribute anonymous build time data to the Quarkus community? (y/n)

I'm not not sure having * to draw the user attention works well, I had it shown like this in my terminal window:

*********************************************************************************
***********************
*********************************************************************************
***********************
*********************************************************************************
***********************
* Please help improve Quarkus!
* Learn more: https://quarkus.io/usage/
* Do you agree to contribute anonymous build time data to the Quarkus community? (y/n)

but also my initial reaction this was reported by some forgotten debug log message in the Quarkus code.
It looks fine after the first try, but if instead of * we could have a Quarkus Build Time Analytics banner it would likely look better.

The other possible problem is that if someone is looking at this message for longer than 10 secs, for example, goes to https://quarkus.io/usage/, before deciding to press n, then the analytics decision will be done automatically and the question won't be asked again next time the application starts. Therefore, after the decision has been taken, either by the user selecting y or n or taken automatically, it could be useful to print a message informing the user how it can be changed/reverted if preferred later

Implementation ideas

  • Consider replacing a sequence of * with the banner representing the analytics feature
  • Consider informing users how to change the analytics status
@geoand
Copy link
Contributor

geoand commented Jun 26, 2023

cc @brunobat

@brunobat
Copy link
Contributor

@insectengine @maxandersen @paulrobinson What's your take on this?

@brunobat brunobat self-assigned this Jun 26, 2023
@maxandersen
Copy link
Member

then the analytics decision will be done automatically and the question won't be asked again next time the application starts.

that should not be the case. if user have not pressed something we treat it as not-answered.

Consider replacing a sequence of * with the banner representing the analytics feature

I really don't like the screen wide *'s but also don't think an actual banner will be useful.

How about just:

***Help improve Quarkus***

* Learn more: https://quarkus.io/usage/
* Do you agree to contribute anonymous build time data to the Quarkus community? (y/n)

Consider informing users how to change the analytics status

quarkus.io/usage has that info - printing those instructions everytime build/devmode happens would be noisy would it not ?

@brunobat
Copy link
Contributor

I would prefer to have it more visible and I'm agains displaying anything apart from the 1st dev mode execution/answer.

@maxandersen
Copy link
Member

More visible than what ?

The current form is ultra visible and quite invasive ( as it's very wide ).

I think we can do with less.

Got any counter proposals to my simplified version?

@insectengine
Copy link
Contributor

I agree there needs to be a visual break to indicate to the users something is happening. Instead of a long trail of asterisks that wraps oddly in smaller windows, how about 3 rows of say 20 or 30?

@brunobat
Copy link
Contributor

brunobat commented Jun 26, 2023

Something like:

*****************************
*****************************
*** Help improve Quarkus ***

* Learn more: https://quarkus.io/usage/
* Do you agree to contribute anonymous build time data to the Quarkus community? (y/n)

And because @sberyozkin was complaining about *, an alternative:

----------------------------
----------------------------
--- Help improve Quarkus ---

* Learn more: https://quarkus.io/usage/
* Do you agree to contribute anonymous build time data to the Quarkus community? (y/n)

After looking at it, I kind of like this last alternative.

@insectengine
Copy link
Contributor

insectengine commented Jun 26, 2023

I like where it's going... but how aobut a row of dashes, the "Help improve Quarkus", then another row? (some reason, I can't make it present her without taking on styling.)

@brunobat
Copy link
Contributor

How about this?

----------------------------
----------------------------
--- Help improve Quarkus ---
----------------------------
* Learn more: https://quarkus.io/usage/
* Do you agree to contribute anonymous build time data to the Quarkus community? (y/n)

@insectengine
Copy link
Contributor

works for me

@paulrobinson
Copy link
Contributor

I think it looks clear, tidy and intentional.

@brunobat
Copy link
Contributor

@sberyozkin @maxandersen Are you ok with this?

@maxandersen
Copy link
Member

looks good but letse not overdo the number of lines :)

The exact same but just 3 lines for the banner rather than 4 lines.

----------------------------
--- Help improve Quarkus ---
----------------------------
* Learn more: https://quarkus.io/usage/
* Do you agree to contribute anonymous build time data to the Quarkus community? (y/n)

lets do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devmode kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants