-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve build time analytics message shown at the start up time #34284
Comments
cc @brunobat |
@insectengine @maxandersen @paulrobinson What's your take on this? |
that should not be the case. if user have not pressed something we treat it as not-answered.
I really don't like the screen wide *'s but also don't think an actual banner will be useful. How about just:
quarkus.io/usage has that info - printing those instructions everytime build/devmode happens would be noisy would it not ? |
I would prefer to have it more visible and I'm agains displaying anything apart from the 1st dev mode execution/answer. |
More visible than what ? The current form is ultra visible and quite invasive ( as it's very wide ). I think we can do with less. Got any counter proposals to my simplified version? |
I agree there needs to be a visual break to indicate to the users something is happening. Instead of a long trail of asterisks that wraps oddly in smaller windows, how about 3 rows of say 20 or 30? |
Something like:
And because @sberyozkin was complaining about *, an alternative:
After looking at it, I kind of like this last alternative. |
I like where it's going... but how aobut a row of dashes, the "Help improve Quarkus", then another row? (some reason, I can't make it present her without taking on styling.) |
How about this?
|
works for me |
I think it looks clear, tidy and intentional. |
@sberyozkin @maxandersen Are you ok with this? |
looks good but letse not overdo the number of lines :) The exact same but just 3 lines for the banner rather than 4 lines.
lets do it. |
Description
The following message is shown at the start up time with
3.2.0.CR1
:I'm not not sure having
*
to draw the user attention works well, I had it shown like this in my terminal window:but also my initial reaction this was reported by some forgotten debug log message in the Quarkus code.
It looks fine after the first try, but if instead of
*
we could have a Quarkus Build Time Analytics banner it would likely look better.The other possible problem is that if someone is looking at this message for longer than 10 secs, for example, goes to
https://quarkus.io/usage/
, before deciding to pressn
, then the analytics decision will be done automatically and the question won't be asked again next time the application starts. Therefore, after the decision has been taken, either by the user selectingy
orn
or taken automatically, it could be useful to print a message informing the user how it can be changed/reverted if preferred laterImplementation ideas
*
with the banner representing the analytics featureThe text was updated successfully, but these errors were encountered: