Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using ZipProjectWriter with CreateProject, Projects should be generated in a folder #3340

Closed
ia3andy opened this issue Jul 26, 2019 · 6 comments
Labels
kind/bug Something isn't working
Milestone

Comments

@ia3andy
Copy link
Contributor

ia3andy commented Jul 26, 2019

This issue was reported on the launcher quarkusio/code.quarkus.io#65 by @jclingan

When unzipping a project, the contents are extracted into the current directory. Example:

$ unzip -t my-app.zip
Archive:  my-app.zip
    testing: src/main/java/           OK
    testing: src/test/java/           OK
    ...

Project content should be extracted into a folder based on the project name:

$ unzip -t my-app.zip
Archive:  my-app.zip
    testing: my-app/src/main/java/           OK
    testing: my-app/src/test/java/           OK
    ...
@ia3andy ia3andy added the kind/bug Something isn't working label Jul 26, 2019
@stale
Copy link

stale bot commented Nov 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you!
We are doing this automatically to ensure out-of-date issues does not stay around indefinitely.
If you believe this issue is still relevant please put a comment on it on why and if it truly needs to stay request or add 'pinned' label.

@stale stale bot added the stale label Nov 13, 2019
@maxandersen maxandersen removed the stale label Nov 13, 2019
@gsmet
Copy link
Member

gsmet commented Nov 18, 2019

@ia3andy isn't this one solved for a long time?

@ia3andy
Copy link
Contributor Author

ia3andy commented Nov 19, 2019

@gsmet no it's only solved on Code Quarkus. I started something with common zip and need some time to complete it. I am adding it to my task list..

@ia3andy
Copy link
Contributor Author

ia3andy commented Apr 7, 2020

I will pick that one up when I start working on the codegen..

@ia3andy
Copy link
Contributor Author

ia3andy commented May 19, 2020

This is the related codegen issue:
#8178

I intend to remove the ZipProjectWriter and instead provide a way to zip/unzip a project folder (when it's already generated).

@ia3andy
Copy link
Contributor Author

ia3andy commented Jun 15, 2020

Finally done: #9631

Instead of having a ZipProjectWriter we now have a QuarkusProjectCompress#zip able to zip any existing Quarkus project.

@ia3andy ia3andy closed this as completed Jun 15, 2020
@gsmet gsmet added this to the 1.6.0 - master milestone Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants