Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread pinning with PostgreSQL JDBC driver #33337

Closed
davecramer opened this issue May 13, 2023 Discussed in #33325 · 6 comments · Fixed by #36553
Closed

Thread pinning with PostgreSQL JDBC driver #33337

davecramer opened this issue May 13, 2023 Discussed in #33325 · 6 comments · Fixed by #36553

Comments

@davecramer
Copy link

Discussed in #33325

Originally posted by davecramer May 12, 2023
This https://quarkus.io/guides/virtual-threads#pinning-cases should now be historical with the release of 42.6.0 of the PostgreSQL JDBC driver. Virtually all synchronized methods have been replaced with reentrant lock. See https://jdbc.postgresql.org/changelogs/2023-03-17-42.6.0-release/ for details.
It would be great if you could update your site to reflect the current state.

@quarkus-bot
Copy link

quarkus-bot bot commented May 15, 2023

/cc @MichalMaler (documentation), @ebullient (documentation), @hmanwani-rh (documentation), @inoxx03 (documentation), @michelle-purcell (documentation), @sheilamjones (documentation), @sunayna15 (documentation)

@rolfedh
Copy link
Contributor

rolfedh commented Oct 16, 2023

Hi @davecramer. Thanks for reporting this doc issue. I've validated the Pinning cases content with @cescoffier, and added a link to the When Quarkus meets Virtual Threads blog post. Please let me know if you're satisfied with the results. If so, I'll close this issue.

@davecramer
Copy link
Author

@rolfedh Hi, thanks for addressing this. Any chance you could add something to the effect of "as of version 42.2.6 this is no longer the case" or even "old versions (before 42.2.6)" ?

Cheers,
Dave

@rolfedh
Copy link
Contributor

rolfedh commented Oct 18, 2023

Hi, @cescoffier. What do you think about Dave's proposal?

@cescoffier
Copy link
Member

Sure, we can mention the version.

@rolfedh
Copy link
Contributor

rolfedh commented Oct 18, 2023

Hi @davecramer, please have a look at https://github.com/quarkusio/quarkus/pull/36553/files and leave any suggestions or an lgtm there. Thanks. Then, I'll run it by the team for approval and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

5 participants