Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a way to customize quarkus' micrometer MeterRegistry/CompositeMeterRegistry #32996

Closed
manofthepeace opened this issue Apr 28, 2023 · 2 comments · Fixed by #34573
Closed

Provide a way to customize quarkus' micrometer MeterRegistry/CompositeMeterRegistry #32996

manofthepeace opened this issue Apr 28, 2023 · 2 comments · Fixed by #34573
Labels
area/metrics kind/enhancement New feature or request
Milestone
3.3.0.CR1

Comments

@manofthepeace
Copy link
Contributor

Description

We use quarkus-micrometer-registry-prometheus and it took us a long (very long) while to realize we had an issue with some of our metrics, because we do not get the micrometer errors via its MeterRegistry.

We found out about our issue by adding a onMeterRegistrationFailed listener to the quarkus' CompositeMeterRegistry.

To add that listener we had to modify and injecter MeterRegistry in a startup bean so it can be done early enough.

It would be nice to have a way to tweak the CompositeMeterRegistry out of the box so we can modify it's configuration.

Implementation ideas

No response
@manofthepeace manofthepeace added the kind/enhancement New feature or request label Apr 28, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 28, 2023

/cc @brunobat (micrometer), @ebullient (micrometer)

geoand added a commit to geoand/quarkus that referenced this issue Jul 6, 2023
@geoand
Introduce a way to completely customize MeterRegistry
39d2767 
This is done via the new `MeterRegistryCustomizer` interface
the implementations of which are meant to be registered as
CDI beans.

Closes: quarkusio#32996
@geoand geoand mentioned this issue Jul 6, 2023
Merged
@geoand
Copy link
Contributor

geoand commented Jul 6, 2023

#34573 is what I have in mind

geoand added a commit to geoand/quarkus that referenced this issue Jul 6, 2023
@geoand
Introduce a way to completely customize MeterRegistry
51ded6b 
This is done via the new `MeterRegistryCustomizer` interface
the implementations of which are meant to be registered as
CDI beans.

Closes: quarkusio#32996
geoand added a commit to geoand/quarkus that referenced this issue Jul 7, 2023
@geoand
Introduce a way to completely customize MeterRegistry
fbd6e52 
This is done via the new `MeterRegistryCustomizer` interface
the implementations of which are meant to be registered as
CDI beans.

Closes: quarkusio#32996
geoand added a commit that referenced this issue Jul 7, 2023
@geoand
Merge pull request #34573 from geoand/#32996
34e133b 
Introduce a way to completely customize MeterRegistry
@github-project-automation github-project-automation bot moved this from Todo to Done in Quarkus Roadmap/Planning Jul 7, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Jul 7, 2023
@holomekc holomekc mentioned this issue Aug 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/metrics kind/enhancement New feature or request
Projects
Quarkus Roadmap/Planning
Status: Done
Milestone
3.3.0.CR1
Development

Successfully merging a pull request may close this issue.

Introduce a way to completely customize MeterRegistry geoand/quarkus
2 participants
@geoand @manofthepeace