Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable OIDC code flow access token verification if JsonWebToken is injected #32958

Closed
sberyozkin opened this issue Apr 27, 2023 · 2 comments
Closed
Assignees
Labels
area/oidc kind/enhancement New feature or request triage/duplicate This issue or pull request already exists

Comments

@sberyozkin
Copy link
Member

Description

OIDC bearer access token are always verified, with the code flow, ID token is a primary token which is verified by default, the code flow access tokens are of no of interest to Quarkus itself in many cases, but the users can tell Quarkus to verify the access token if the access token is used a source of roles for example.

Code flow access token verification was enabled by default at some point but with so many providers issuing binary access tokens, and having no way to directly introspect them, it caused a lot of problems for the users.

However, if, at build time, we can detect that the access token is not binary but JSON, i.e, JsonWebToken is injected, and therefore the endpoint may use its claims to make some decisions, the verification will have to be enabled by default, without requiring the users to enable the access token verification themselves, making it more secure by default.

This issue is based on the feedback from @pmlopes, thanks Paulo.

Implementation ideas

No response

@sberyozkin sberyozkin added the kind/enhancement New feature or request label Apr 27, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 27, 2023

/cc @pedroigor (oidc)

@sberyozkin sberyozkin self-assigned this Apr 27, 2023
@sberyozkin sberyozkin added the triage/duplicate This issue or pull request already exists label Mar 19, 2024
@sberyozkin
Copy link
Member Author

Duplicate of #39427 which was resolved by @michalvavrik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/oidc kind/enhancement New feature or request triage/duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

1 participant