Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI - introduce clean command #30774

Closed
rsvoboda opened this issue Feb 1, 2023 · 4 comments · Fixed by #30790
Closed

CLI - introduce clean command #30774

rsvoboda opened this issue Feb 1, 2023 · 4 comments · Fixed by #30790
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/jbang Issues related to when using jbang.dev with Quarkus kind/enhancement New feature or request
Milestone

Comments

@rsvoboda
Copy link
Member

rsvoboda commented Feb 1, 2023

Description

Introduce clean command for CLI.

ATM CLI has commands build, dev, test, ... But there is no clean command.

As a workaround I run mvn clean to get fresh start, e.g. when running dev mode and changing Quarkus version.

I think clean could be invoked for maven and gradle, not sure about JBang.
For JBang based app there is no quarkus dev support for it, so maybe similar error message approach could be used.

quarkus dev
[ERROR] ❗  Unable to launch project in dev mode: Not there yet. ;)

Implementation ideas

No response

@rsvoboda rsvoboda added the kind/enhancement New feature or request label Feb 1, 2023
@quarkus-bot quarkus-bot bot added area/cli Related to quarkus cli (not maven/gradle/etc.) area/jbang Issues related to when using jbang.dev with Quarkus labels Feb 1, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 1, 2023

/cc @ebullient (cli), @maxandersen (cli,jbang), @quarkusio/devtools (jbang)

@maxandersen
Copy link
Member

Clean is done with 'quarkus build --clean' afair?

Deliberately not added as seperate command as we don't allow combinations like mvn/gradle does.

Ps. jbang -Dquarkus.dev ... should work at least for single files. Should get that wired up to quarkus dev

@rsvoboda
Copy link
Member Author

rsvoboda commented Feb 1, 2023

Got it. One needs to check quarkus build --help or quarkus dev --help to see --[no-]clean options.

I'm not sure if we document it in cli tooling guide (or if it's worth doing so).

I was unaware of that option and got annoyed by my flow when I was running mvn clean instead of just using Quarkus CLI.

@rsvoboda
Copy link
Member Author

rsvoboda commented Feb 1, 2023

I have created #30790 for a note in CLI guide, assigned to @maxandersen .

@quarkus-bot quarkus-bot bot added this to the 2.17 - main milestone Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/jbang Issues related to when using jbang.dev with Quarkus kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants