Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus 3.0 codestarts for Gradle have javax in allopen rather than jakarta #30582

Closed
GavinRay97 opened this issue Jan 24, 2023 · 12 comments · Fixed by #30587 or #30660
Closed

Quarkus 3.0 codestarts for Gradle have javax in allopen rather than jakarta #30582

GavinRay97 opened this issue Jan 24, 2023 · 12 comments · Fixed by #30587 or #30660
Assignees
Milestone

Comments

@GavinRay97
Copy link
Contributor

Describe the bug

Not sure if intentional, but generating a Quarkus 3.0 Gradle KTS codestart gives me:

quarkusPluginId=io.quarkus
quarkusPluginVersion=3.0.0.Alpha3
quarkusPlatformGroupId=io.quarkus.platform
quarkusPlatformArtifactId=quarkus-bom
quarkusPlatformVersion=3.0.0.Alpha3
allOpen {
    annotation("javax.ws.rs.Path")
    annotation("javax.enterprise.context.ApplicationScoped")
    annotation("io.quarkus.test.junit.QuarkusTest")
}

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@GavinRay97 GavinRay97 added the kind/bug Something isn't working label Jan 24, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 24, 2023

/cc @glefloch, @ia3andy (codestart), @quarkusio/devtools (codestart)

@gastaldi
Copy link
Contributor

Looks like we need to apply the changes in the following commit too in 3.0:

9a74058#diff-1fdf13c3faf1e270925515b7c829a57d03c1e4742330f889b30b369976928005R303-R304

@glefloch
Copy link
Member

right, I will update kotlin codestart code.

@gastaldi
Copy link
Contributor

Actually it was already updated in 51e819c and should be available in the next release

@gastaldi gastaldi closed this as not planned Won't fix, can't repro, duplicate, stale Jan 24, 2023
@GavinRay97
Copy link
Contributor Author

Ah, sorry for an invalid issue!

@gastaldi
Copy link
Contributor

@gastaldi gastaldi reopened this Jan 24, 2023
@quarkus-bot quarkus-bot bot added this to the 2.17 - main milestone Jan 24, 2023
@gsmet gsmet reopened this Jan 25, 2023
@gsmet
Copy link
Member

gsmet commented Jan 25, 2023

I will have a look as if you’re using Alpha3, it should be already fine.

@gsmet gsmet self-assigned this Jan 25, 2023
@gsmet gsmet removed this from the 2.17 - main milestone Jan 27, 2023
@gastaldi
Copy link
Contributor

@gsmet isn't #30587 supposed to fix this?

@gsmet
Copy link
Member

gsmet commented Jan 27, 2023

I'm not sure yet. I think it fixes the issue with the gradle file AFAICS (but I'm unsure as I have no real idea about what was the initial issue...) but the kts file was already correct so I need to test it more.

@gsmet
Copy link
Member

gsmet commented Jan 27, 2023

@gastaldi #30587 broke the Jakarta build so that doesn't help to get the issue fixed :). I will push a fix soon.

@gsmet
Copy link
Member

gsmet commented Jan 27, 2023

BTW, I'm still unsure as to why the Gradle Kotlin Script build file also has the issue while this particular file has been transformed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment