Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev UI — edited property is saved with currently active profile #30511

Closed
fedinskiy opened this issue Jan 20, 2023 · 5 comments
Closed

Dev UI — edited property is saved with currently active profile #30511

fedinskiy opened this issue Jan 20, 2023 · 5 comments
Labels
area/dev-ui kind/bug Something isn't working

Comments

@fedinskiy
Copy link
Contributor

fedinskiy commented Jan 20, 2023

Describe the bug

I have an app, which contains several properties without a profile. When I run the application, edit property via Dev UI and save it, the property is saved in application.properties with currently activated profile (and old property is not changed).

Expected behavior

Saved property should keep it's original profile (or lack of it)

Actual behavior

Property is saved with active profile

How to Reproduce?

  1. git clone https://github.com/rsvoboda/code-with-quarkus
$ cat src/main/resources/application.properties 
quarkus.http.ssl.certificate.key-store-file=META-INF/resources/server.keystore
quarkus.http.ssl.certificate.key-store-password=password
quarkus.datasource.password=foo
  1. mvn quarkus:dev -Dquarkus.profile=any
  2. Access http://localhost:8080/q/dev/io.quarkus.quarkus-vertx-http/config, edit quarkus.datasource.password value to bar, and save it
$ cat src/main/resources/application.properties 
quarkus.http.ssl.certificate.key-store-file=META-INF/resources/server.keystore
quarkus.http.ssl.certificate.key-store-password=password
quarkus.datasource.password=foo
%any.quarkus.datasource.password=bar

Output of uname -a or ver

8.0.18-300.fc37.x86_64

Output of java -version

17.0.4, vendor: GraalVM Community

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.14.2.Final

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

This bug also reproduces on 2.15.3.Final

@fedinskiy fedinskiy added the kind/bug Something isn't working label Jan 20, 2023
@fedinskiy
Copy link
Contributor Author

Probably this belongs to area/dev-ui , same as the original #29431

@fedinskiy
Copy link
Contributor Author

Result on the latest build(653954d) is slightly different:

quarkus.http.ssl.certificate.key-store-file=META-INF/resources/server.keystore
quarkus.http.ssl.certificate.key-store-password=password
quarkus.datasource.password=foo
quarkus.datasource.password=foobar # new value

@fedinskiy
Copy link
Contributor Author

@iocanel @phillip-kruger you seem to be handling most of area/dev-ui issues, any chance one of you can take a look at this?

@phillip-kruger
Copy link
Member

This is in v2? What is the behaviour in v3?

@fedinskiy
Copy link
Contributor Author

@phillip-kruger hmm, looks like it is working as expected in http://localhost:8080/q/dev-ui/configuration-form-editor of 3.7.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev-ui kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants