Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevUI CORS - hostname dns reverse lookup use-case #29462

Open
rsvoboda opened this issue Nov 24, 2022 · 1 comment
Open

DevUI CORS - hostname dns reverse lookup use-case #29462

rsvoboda opened this issue Nov 24, 2022 · 1 comment
Labels
area/dev-ui kind/enhancement New feature or request

Comments

@rsvoboda
Copy link
Member

Description

DevUI CORS - enable hostname dns reverse lookup use-case, relates to #29342 (comment)

Current hostname (rsvoboda-mac in my case) use-case behaviour:
Changing value using http://rsvoboda-mac:8080/api/q/dev/io.quarkus.quarkus-vertx-http/config triggers 2022-11-23 09:45:31,871 ERROR [io.qua.ver.htt.run.dev.DevConsoleCORSFilter] (vert.x-eventloop-thread-0) Only localhost origin is allowed, but Origin header value is: http://rsvoboda-mac:8080

traceroute rsvoboda-mac                                                                                                                                               
traceroute to localhost (127.0.0.1), 64 hops max, 52 byte packets
 1  localhost (127.0.0.1)  0.611 ms  0.050 ms  0.040 ms

Implementation ideas

We have DevUI specific CORS config group. We can add a property there, allow-dns-reverse-lookup, which, if set to true will allow us check if the current DNS name resolves to localhost.

This is not super urgent, maybe we can keep the issue around and see if people vote for this or not.

CC @sberyozkin, @cescoffier

@rsvoboda rsvoboda added the kind/enhancement New feature or request label Nov 24, 2022
@cescoffier
Copy link
Member

It needs to be explicit, but rather than that, great idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev-ui kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants