Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix kafka consumer client.id with quarkus.application.name #26809

Closed
mrickly opened this issue Jul 19, 2022 · 6 comments
Closed

Prefix kafka consumer client.id with quarkus.application.name #26809

mrickly opened this issue Jul 19, 2022 · 6 comments
Labels
area/kafka kind/enhancement New feature or request

Comments

@mrickly
Copy link

mrickly commented Jul 19, 2022

Description

Implementation ideas

No response

@mrickly mrickly added the kind/enhancement New feature or request label Jul 19, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 19, 2022

/cc @alesj, @cescoffier, @ozangunalp

@cescoffier
Copy link
Member

Can't you set the client id explicitly in your application using ${quarkus.application.name}-your-id?

I'm not against that change, but it's a breaking change. So, we need to have an attribute to change the behavior (which would be another attribute, that's why my initial proposal could work as it is.)

@mrickly
Copy link
Author

mrickly commented Jul 20, 2022

Sure we could. I'd rather not force every developing team to configure it explicitly for each incoming channel in their application though. We do pre-configure certain properties in our own extensions (quarkus-extension.yaml). However I don't see how that would work with variable channels... Maybe you have an idea how it could be done?

A non-breaking variant would be to add a prefix property with a "" default which would be applied to all client ids.

@cescoffier
Copy link
Member

I like your proposal. We could define a global prefix attribute, and if the prefix is configured, it will be prepended.

@ozangunalp WDYT?

@ozangunalp
Copy link
Contributor

This needs to be done in Smallrye Reactive Messaging.
Here is my proposal : smallrye/smallrye-reactive-messaging#1909

@cescoffier
Copy link
Member

Fixed by #28117.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kafka kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants