-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefix kafka consumer client.id with quarkus.application.name #26809
Comments
/cc @alesj, @cescoffier, @ozangunalp |
Can't you set the client id explicitly in your application using ${quarkus.application.name}-your-id? I'm not against that change, but it's a breaking change. So, we need to have an attribute to change the behavior (which would be another attribute, that's why my initial proposal could work as it is.) |
Sure we could. I'd rather not force every developing team to configure it explicitly for each incoming channel in their application though. We do pre-configure certain properties in our own extensions (quarkus-extension.yaml). However I don't see how that would work with variable channels... Maybe you have an idea how it could be done? A non-breaking variant would be to add a prefix property with a "" default which would be applied to all client ids. |
I like your proposal. We could define a global prefix attribute, and if the prefix is configured, it will be prepended. @ozangunalp WDYT? |
This needs to be done in Smallrye Reactive Messaging. |
Fixed by #28117. |
Description
Implementation ideas
No response
The text was updated successfully, but these errors were encountered: